Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 79442d49cf75d2d5e5b6325e3af7cb98da990684
https://github.com/WebKit/WebKit/commit/79442d49cf75d2d5e5b6325e3af7cb98da990684
Author: Anuj Panta <[email protected]>
Date: 2026-04-24 (Fri, 24 Apr 2026)
Changed paths:
M
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-in-cross-origin-iframe-expected.txt
M
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-in-cross-origin-iframe.html
M
LayoutTests/http/tests/site-isolation/inspector/runtime/executionContextCreated-frame-target-expected.txt
M
LayoutTests/http/tests/site-isolation/inspector/runtime/executionContextCreated-frame-target.html
M LayoutTests/platform/mac-wk2/TestExpectations
Log Message:
-----------
[Site Isolation] Web Inspector: Fix Runtime layout tests for cross-origin
frame targets
https://bugs.webkit.org/show_bug.cgi?id=311136
rdar://173722617
Reviewed by Qianlang Chen.
These tests were failing because they dynamically created cross-origin
iframes and used TargetAdded to acquire the frame target. Under site
isolation, this resolved with the initial about:blank target instead
of the committed cross-origin target. The about:blank target never
receives an execution context since reportExecutionContextCreation()
skips the initial empty document.
Also fixed evaluate-in-cross-origin-iframe.html which referenced
WI.FrameTarget.Event.PageExecutionContextChanged — an event that
only exists on WI.Frame, not WI.FrameTarget, causing awaitEvent to
wait on undefined and time out.
Switched to static cross-origin iframes declared in the test HTML.
By the time onload fires, the provisional target lifecycle has
completed and the committed frame target is already available with
its execution context set. Uses fetchDocumentURLsForTargets to
identify the cross-origin target.
*
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-in-cross-origin-iframe-expected.txt:
*
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-in-cross-origin-iframe.html:
*
LayoutTests/http/tests/site-isolation/inspector/runtime/executionContextCreated-frame-target-expected.txt:
*
LayoutTests/http/tests/site-isolation/inspector/runtime/executionContextCreated-frame-target.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/311959@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
