Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 50090123ba32077238770aeb789f0b1029e58874
https://github.com/WebKit/WebKit/commit/50090123ba32077238770aeb789f0b1029e58874
Author: Alan Baradlay <[email protected]>
Date: 2026-04-24 (Fri, 24 Apr 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderReplaced.cpp
Log Message:
-----------
Rename isAnonymousForPercentageResolution to shouldSkipForPercentageResolution
https://bugs.webkit.org/show_bug.cgi?id=313232
Reviewed by Antti Koivisto.
The old name focused on the "anonymous" property, but the function's purpose
is to decide whether a block should be skipped when walking the containing
block chain for percentage resolution. The new name describes the behavior.
Also moved the RenderView early return from
skipContainingBlockForPercentHeightCalculation
into the quirks mode lambda where it belongs -- RenderView should not be skipped
despite having auto height, same as flex containers and grid.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation const):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::containingBlockForAutoHeightDetectionGeneric
const):
(WebCore::hasDefiniteHeightByStyle):
* Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::shouldSkipForPercentageResolution const):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalHeightUsingGeneric const):
Canonical link: https://commits.webkit.org/311975@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
