Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 906bdfad2925e9db82b1da7caee954c1dac89710
https://github.com/WebKit/WebKit/commit/906bdfad2925e9db82b1da7caee954c1dac89710
Author: Marcos Caceres <[email protected]>
Date: 2026-04-24 (Fri, 24 Apr 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/credential-management/WEB_FEATURES.yml
M
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-create-basics.https.html
M
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-get-basics.https-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/credential-management/credentialscontainer-get-basics.https.html
A
LayoutTests/imported/w3c/web-platform-tests/credential-management/historical.https-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/credential-management/historical.https.html
M
LayoutTests/imported/w3c/web-platform-tests/credential-management/non-fully-active.https.html
M
LayoutTests/imported/w3c/web-platform-tests/credential-management/w3c-import.log
M
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/create.disabled-by-permissions-policy.https.sub-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/default-permissions-policy.https.sub-expected.txt
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h
M Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl
M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp
A
Source/WebCore/Modules/credentialmanagement/FederatedCredentialRequestOptions.h
A
Source/WebCore/Modules/credentialmanagement/FederatedCredentialRequestOptions.idl
A
Source/WebCore/Modules/credentialmanagement/IdentityCredentialRequestOptions.h
A
Source/WebCore/Modules/credentialmanagement/IdentityCredentialRequestOptions.idl
A Source/WebCore/Modules/credentialmanagement/OTPCredentialRequestOptions.h
A
Source/WebCore/Modules/credentialmanagement/OTPCredentialRequestOptions.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
Log Message:
-----------
Cred Man: Define which types are allowed in the same get() request
rdar://173918198
https://bugs.webkit.org/show_bug.cgi?id=310788
Reviewed by Pascoe.
Implements the credential type registry check from the Credential Management
spec (https://www.w3.org/TR/credential-management-1/#credential-type-registry),
as added by https://github.com/w3c/webappsec-credential-management/pull/261.
navigator.credentials.get() now rejects with NotSupportedError when called
with an invalid combination of credential types (e.g. publicKey + password),
and rejects with NotSupportedError when called with no credential type at all.
The only valid multi-type combination is password + federated, which resolves
with null (no stored credentials).
To support the combination check, three stub dictionaries are added:
FederatedCredentialRequestOptions, IdentityCredentialRequestOptions, and
OTPCredentialRequestOptions. These have no members; they exist solely to make
the credential types recognizable to the WebIDL bindings so the combination
check can fire.
Upstream commit:
https://github.com/web-platform-tests/wpt/commit/b592ce44eb85d5276d5743c731a8fb8e33508faf
Canonical link: https://commits.webkit.org/311988@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
