Title: [114728] trunk/Source
Revision
114728
Author
pilg...@chromium.org
Date
2012-04-20 01:49:18 -0700 (Fri, 20 Apr 2012)

Log Message

[Chromium] Call cacheMetadata directly
https://bugs.webkit.org/show_bug.cgi?id=84415

Reviewed by Kentaro Hara.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (114727 => 114728)


--- trunk/Source/WebCore/ChangeLog	2012-04-20 08:41:08 UTC (rev 114727)
+++ trunk/Source/WebCore/ChangeLog	2012-04-20 08:49:18 UTC (rev 114728)
@@ -1,5 +1,19 @@
 2012-04-20  Mark Pilgrim  <pilg...@chromium.org>
 
+        [Chromium] Call cacheMetadata directly
+        https://bugs.webkit.org/show_bug.cgi?id=84415
+
+        Reviewed by Kentaro Hara.
+
+        Part of a refactoring series. See tracking bug 82948.
+
+        * platform/chromium/PlatformSupport.h:
+        (PlatformSupport):
+        * platform/network/chromium/ResourceHandle.cpp:
+        (WebCore::ResourceHandle::cacheMetadata):
+
+2012-04-20  Mark Pilgrim  <pilg...@chromium.org>
+
         [Chromium] Call stopSharedTimer directly
         https://bugs.webkit.org/show_bug.cgi?id=84418
 

Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (114727 => 114728)


--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-04-20 08:41:08 UTC (rev 114727)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h	2012-04-20 08:49:18 UTC (rev 114728)
@@ -93,9 +93,6 @@
 
 class PlatformSupport {
 public:
-    // Cache --------------------------------------------------------------
-    static void cacheMetadata(const KURL&, double responseTime, const Vector<char>&);
-
     // Clipboard ----------------------------------------------------------
     static uint64_t clipboardSequenceNumber(PasteboardPrivate::ClipboardBuffer);
 

Modified: trunk/Source/WebCore/platform/network/chromium/ResourceHandle.cpp (114727 => 114728)


--- trunk/Source/WebCore/platform/network/chromium/ResourceHandle.cpp	2012-04-20 08:41:08 UTC (rev 114727)
+++ trunk/Source/WebCore/platform/network/chromium/ResourceHandle.cpp	2012-04-20 08:49:18 UTC (rev 114728)
@@ -31,7 +31,6 @@
 #include "config.h"
 #include "ResourceHandle.h"
 
-#include "PlatformSupport.h"
 #include "ResourceHandleClient.h"
 #include "ResourceHandleInternal.h"
 #include "ResourceRequest.h"
@@ -290,8 +289,7 @@
 // static
 void ResourceHandle::cacheMetadata(const ResourceResponse& response, const Vector<char>& data)
 {
-    // FIXME: This should use Platform::current() directly.
-    PlatformSupport::cacheMetadata(response.url(), response.responseTime(), data);
+    WebKit::Platform::current()->cacheMetadata(response.url(), response.responseTime(), data.data(), data.size());
 }
 
 } // namespace WebCore

Modified: trunk/Source/WebKit/chromium/ChangeLog (114727 => 114728)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-04-20 08:41:08 UTC (rev 114727)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-04-20 08:49:18 UTC (rev 114728)
@@ -1,5 +1,17 @@
 2012-04-20  Mark Pilgrim  <pilg...@chromium.org>
 
+        [Chromium] Call cacheMetadata directly
+        https://bugs.webkit.org/show_bug.cgi?id=84415
+
+        Reviewed by Kentaro Hara.
+
+        Part of a refactoring series. See tracking bug 82948.
+
+        * src/PlatformSupport.cpp:
+        (WebCore):
+
+2012-04-20  Mark Pilgrim  <pilg...@chromium.org>
+
         [Chromium] Call stopSharedTimer directly
         https://bugs.webkit.org/show_bug.cgi?id=84418
 

Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (114727 => 114728)


--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-04-20 08:41:08 UTC (rev 114727)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp	2012-04-20 08:49:18 UTC (rev 114728)
@@ -144,13 +144,6 @@
     return cookieJar;
 }
 
-// Cache ----------------------------------------------------------------------
-
-void PlatformSupport::cacheMetadata(const KURL& url, double responseTime, const Vector<char>& data)
-{
-    webKitPlatformSupport()->cacheMetadata(url, responseTime, data.data(), data.size());
-}
-
 // Clipboard ------------------------------------------------------------------
 
 uint64_t PlatformSupport::clipboardSequenceNumber(PasteboardPrivate::ClipboardBuffer buffer)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to