[webkit-changes] [114731] trunk/Source/WebCore

Fri, 20 Apr 2012 02:29:26 -0700

Title: [114731] trunk/Source/WebCore
Revision
114731
Author
hara...@chromium.org
Date
2012-04-20 02:29:18 -0700 (Fri, 20 Apr 2012)

Log Message

Unreviewed, rolling out r114440.
http://trac.webkit.org/changeset/114440
https://bugs.webkit.org/show_bug.cgi?id=84173

Chromium crash

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (114730 => 114731)


--- trunk/Source/WebCore/ChangeLog	2012-04-20 09:28:13 UTC (rev 114730)
+++ trunk/Source/WebCore/ChangeLog	2012-04-20 09:29:18 UTC (rev 114731)
@@ -1,5 +1,18 @@
 2012-04-20  Kentaro Hara  <hara...@chromium.org>
 
+        Unreviewed, rolling out r114440.
+        http://trac.webkit.org/changeset/114440
+        https://bugs.webkit.org/show_bug.cgi?id=84173
+
+        Chromium crash
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateHeader):
+        * bindings/v8/custom/V8NodeCustom.cpp:
+        (WebCore::toV8Slow):
+
+2012-04-20  Kentaro Hara  <hara...@chromium.org>
+
         Unreviewed, rolling out r114519.
         http://trac.webkit.org/changeset/114519
         https://bugs.webkit.org/show_bug.cgi?id=84202

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (114730 => 114731)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-20 09:28:13 UTC (rev 114730)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-04-20 09:29:18 UTC (rev 114731)
@@ -456,18 +456,18 @@
     } else {
         push(@headerContent, <<END);
 
-v8::Handle<v8::Value> toV8Slow(Node*, v8::Isolate*, bool);
+v8::Handle<v8::Value> toV8Slow(Node*, bool);
 
 inline v8::Handle<v8::Value> toV8(Node* impl, v8::Isolate* isolate = 0, bool forceNewObject = false)
 {
     if (UNLIKELY(!impl))
         return v8::Null();
     if (UNLIKELY(forceNewObject))
-        return toV8Slow(impl, isolate, forceNewObject);
+        return toV8Slow(impl, forceNewObject);
     v8::Handle<v8::Value> wrapper = V8DOMWrapper::getCachedWrapper(impl);
     if (!wrapper.IsEmpty())
         return wrapper;
-    return toV8Slow(impl, isolate, false);
+    return toV8Slow(impl, false);
 }
 END
     }

Modified: trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp (114730 => 114731)


--- trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp	2012-04-20 09:28:13 UTC (rev 114730)
+++ trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp	2012-04-20 09:29:18 UTC (rev 114731)
@@ -136,7 +136,7 @@
     return v8::Null();
 }
 
-v8::Handle<v8::Value> toV8Slow(Node* impl, v8::Isolate* isolate, bool forceNewObject)
+v8::Handle<v8::Value> toV8Slow(Node* impl, bool forceNewObject)
 {
     if (!impl)
         return v8::Null();
@@ -149,34 +149,34 @@
     switch (impl->nodeType()) {
     case Node::ELEMENT_NODE:
         if (impl->isHTMLElement())
-            return toV8(toHTMLElement(impl), isolate, forceNewObject);
+            return toV8(toHTMLElement(impl), 0, forceNewObject);
 #if ENABLE(SVG)
         if (impl->isSVGElement())
-            return toV8(static_cast<SVGElement*>(impl), isolate, forceNewObject);
+            return toV8(static_cast<SVGElement*>(impl), 0, forceNewObject);
 #endif
         return V8Element::wrap(static_cast<Element*>(impl), forceNewObject);
     case Node::ATTRIBUTE_NODE:
-        return toV8(static_cast<Attr*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<Attr*>(impl), 0, forceNewObject);
     case Node::TEXT_NODE:
-        return toV8(toText(impl), isolate, forceNewObject);
+        return toV8(toText(impl), 0, forceNewObject);
     case Node::CDATA_SECTION_NODE:
-        return toV8(static_cast<CDATASection*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<CDATASection*>(impl), 0, forceNewObject);
     case Node::ENTITY_REFERENCE_NODE:
-        return toV8(static_cast<EntityReference*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<EntityReference*>(impl), 0, forceNewObject);
     case Node::ENTITY_NODE:
-        return toV8(static_cast<Entity*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<Entity*>(impl), 0, forceNewObject);
     case Node::PROCESSING_INSTRUCTION_NODE:
-        return toV8(static_cast<ProcessingInstruction*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<ProcessingInstruction*>(impl), 0, forceNewObject);
     case Node::COMMENT_NODE:
-        return toV8(static_cast<Comment*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<Comment*>(impl), 0, forceNewObject);
     case Node::DOCUMENT_NODE:
-        return toV8(static_cast<Document*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<Document*>(impl), 0, forceNewObject);
     case Node::DOCUMENT_TYPE_NODE:
-        return toV8(static_cast<DocumentType*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<DocumentType*>(impl), 0, forceNewObject);
     case Node::DOCUMENT_FRAGMENT_NODE:
-        return toV8(static_cast<DocumentFragment*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<DocumentFragment*>(impl), 0, forceNewObject);
     case Node::NOTATION_NODE:
-        return toV8(static_cast<Notation*>(impl), isolate, forceNewObject);
+        return toV8(static_cast<Notation*>(impl), 0, forceNewObject);
     default: break; // XPATH_NAMESPACE_NODE
     }
     return V8Node::wrap(impl, forceNewObject);

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to