Title: [114758] trunk/Source/WebCore
- Revision
- 114758
- Author
- pfeld...@chromium.org
- Date
- 2012-04-20 10:13:47 -0700 (Fri, 20 Apr 2012)
Log Message
Web Inspector: open file dialog is not centered.
https://bugs.webkit.org/show_bug.cgi?id=84464
Reviewed by Yury Semikhatsky.
There was an error in the positioning logic.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114757 => 114758)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 17:09:00 UTC (rev 114757)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 17:13:47 UTC (rev 114758)
@@ -1,3 +1,15 @@
+2012-04-20 Pavel Feldman <pfeld...@chromium.org>
+
+ Web Inspector: open file dialog is not centered.
+ https://bugs.webkit.org/show_bug.cgi?id=84464
+
+ Reviewed by Yury Semikhatsky.
+
+ There was an error in the positioning logic.
+
+ * inspector/front-end/FilteredItemSelectionDialog.js:
+ (WebInspector.FilteredItemSelectionDialog.prototype.position):
+
2012-04-20 Allan Sandfeld Jensen <allan.jen...@nokia.com>
[Qt] PlatformMouseEventQt.cpp should be deleted.
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (114757 => 114758)
--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2012-04-20 17:09:00 UTC (rev 114757)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2012-04-20 17:13:47 UTC (rev 114758)
@@ -88,8 +88,8 @@
const shadowPadding = 10;
element.positionAt(
- relativeToElement.totalOffsetLeft() + Math.max(relativeToElement.offsetWidth - width - shadowPadding, shadowPadding),
- relativeToElement.totalOffsetTop() + Math.max((relativeToElement.offsetHeight - height) / 2 + shadowPadding, shadowPadding));
+ relativeToElement.totalOffsetLeft() + Math.max((relativeToElement.offsetWidth - width - 2 * shadowPadding) / 2, shadowPadding),
+ relativeToElement.totalOffsetTop() + Math.max((relativeToElement.offsetHeight - height - 2 * shadowPadding) / 2, shadowPadding));
},
focus: function()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
