Title: [114775] trunk/Source/WebCore
- Revision
- 114775
- Author
- e...@chromium.org
- Date
- 2012-04-20 13:22:03 -0700 (Fri, 20 Apr 2012)
Log Message
Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472
Reviewed by Eric Seidel.
Fix use of subpixel units and rounding in new code introduced in r114659.
No new tests, no change in functionality.
* inspector/DOMNodeHighlighter.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114774 => 114775)
--- trunk/Source/WebCore/ChangeLog 2012-04-20 20:07:16 UTC (rev 114774)
+++ trunk/Source/WebCore/ChangeLog 2012-04-20 20:22:03 UTC (rev 114775)
@@ -1,3 +1,16 @@
+2012-04-20 Emil A Eklund <e...@chromium.org>
+
+ Fix use of LayoutUnits in DOMNodeHighlighter
+ https://bugs.webkit.org/show_bug.cgi?id=84472
+
+ Reviewed by Eric Seidel.
+
+ Fix use of subpixel units and rounding in new code introduced in r114659.
+
+ No new tests, no change in functionality.
+
+ * inspector/DOMNodeHighlighter.cpp:
+
2012-04-17 Antonio Gomes <ago...@rim.com>
Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (114774 => 114775)
--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2012-04-20 20:07:16 UTC (rev 114774)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp 2012-04-20 20:22:03 UTC (rev 114775)
@@ -355,10 +355,10 @@
static void contentsQuadToRootView(FloatQuad& quad, FrameView* view)
{
- quad.setP1(view->contentsToRootView(roundedLayoutPoint(quad.p1())));
- quad.setP2(view->contentsToRootView(roundedLayoutPoint(quad.p2())));
- quad.setP3(view->contentsToRootView(roundedLayoutPoint(quad.p3())));
- quad.setP4(view->contentsToRootView(roundedLayoutPoint(quad.p4())));
+ quad.setP1(view->contentsToRootView(roundedIntPoint(quad.p1())));
+ quad.setP2(view->contentsToRootView(roundedIntPoint(quad.p2())));
+ quad.setP3(view->contentsToRootView(roundedIntPoint(quad.p3())));
+ quad.setP4(view->contentsToRootView(roundedIntPoint(quad.p4())));
}
static void getOrDrawNodeHighlight(GraphicsContext* context, HighlightData* highlightData, Highlight* highlight)
@@ -457,7 +457,7 @@
return;
if (context && highlightData->showInfo)
- drawElementTitle(*context, node, renderer, boundingBox, titleAnchorBox, visibleRect, containingFrame->settings());
+ drawElementTitle(*context, node, renderer, pixelSnappedIntRect(boundingBox), pixelSnappedIntRect(titleAnchorBox), visibleRect, containingFrame->settings());
}
static void getOrDrawRectHighlight(GraphicsContext* context, Document* document, HighlightData* highlightData, Highlight *highlight)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
