Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ade76dc877f329736714fef95797a044b1dece29
https://github.com/WebKit/WebKit/commit/ade76dc877f329736714fef95797a044b1dece29
Author: Sihui Liu <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M Source/WebCore/platform/Site.cpp
M Source/WebCore/platform/Site.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessCache.cpp
Log Message:
-----------
Add Site::loggingString() to distinguish sites with different protocols in
logs
https://bugs.webkit.org/show_bug.cgi?id=313563
rdar://175780686
Reviewed by Per Arne Vollan.
Site::toString() returns an empty string for empty sites, making it impossible
to distinguish sites with different
protocols (e.g. "about:blank" vs "data://") in log output. This is important
for debugging as some protocol can get
specical treatment while others do not, e.g.
WebProcessPool::processForNavigationInternal checks for whether protocl is
"about" to decide which process to use. Add a separate loggingString() method
that always includes the protocol, and use
it in RELEASE_LOG call sites and TextStream output.
This avoids changing the behavior of toString(), which is used as a functional
key in cookiePartitionIdentifier().
* Source/WebCore/platform/Site.cpp:
(WebCore::Site::loggingString const):
(WebCore::operator<<):
* Source/WebCore/platform/Site.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::logFrameTreeHelper):
(WebKit::logFrameTreeRoot):
* Source/WebKit/UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::addProcess):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::takeSharedProcess):
Canonical link: https://commits.webkit.org/312559@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
