Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 61d4d4fb14a1c4eedfc8452544d4262e32b6b080
https://github.com/WebKit/WebKit/commit/61d4d4fb14a1c4eedfc8452544d4262e32b6b080
Author: Anthony Tarbinian <[email protected]>
Date: 2026-05-04 (Mon, 04 May 2026)
Changed paths:
M
LayoutTests/http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes-expected.txt
M
LayoutTests/http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes.html
Log Message:
-----------
[Site Isolation]
http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes.html
is flaky on macOS post-commit bot
https://bugs.webkit.org/show_bug.cgi?id=314016
rdar://176211967
Reviewed by Ryosuke Niwa.
http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes.html
is failing flakily with the following diff on macOS site-isolation release
post-commit bots
-CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame
with URL
'http://127.0.0.1:8000/security/block-top-level-navigation-via-redirect-by-third-party-iframes.html'
from frame with URL
'http://localhost:8000/security/resources/navigate-top-level-frame-to-failure-page-via-redirect.html'.
The frame attempting navigation of the top-level
window is cross-origin or untrusted and the user has never interacted with
the frame.
Test blocking of suspicious top-level navigations by a third-party iframe
(same-site but redirects to a different site)
On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".
See
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fblock-top-level-navigation-via-redirect-by-third-party-iframes.html&flavor=site-isolation
https://commits.webkit.org/311805@main attempted to fix this test and added a
1000ms timer
among other changes to fix this test.
That commit was successful in fixing the iOS bots,
but macOS bots are still flaky with the above diff sometimes.
This patch fix replaces the timeout with internals.setConsoleMessageListener,
which finishes the test the moment the console message arrives rather than
guessing
how long to wait.
I was unable to reproduce the macOS bot failure with a local Release build so
this is a
speculative fix.
*
LayoutTests/http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes-expected.txt:
*
LayoutTests/http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes.html:
Canonical link: https://commits.webkit.org/312592@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
