Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6c4c4b8f1ceaa3118b98418de778d8fc72f60f9c
https://github.com/WebKit/WebKit/commit/6c4c4b8f1ceaa3118b98418de778d8fc72f60f9c
Author: Sergio Villar Senin <[email protected]>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/webxr/layers/xrEquirectLayer_paramValidation.https-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/webxr/layers/xrEquirectLayer_paramValidation.https.html
M Source/WebCore/Modules/webxr/XREquirectLayer.cpp
M Source/WebCore/Modules/webxr/XREquirectLayer.h
Log Message:
-----------
[WebXR Layers] Add init and setter param validation for equirect layer
https://bugs.webkit.org/show_bug.cgi?id=313958
Reviewed by Dan Glastonbury.
The equirect layer is defined by a set of values that define its shape.
They can be specified at construction time in the init structure and/or
modified later using the layer setters.
Those values must be validated as not every value is valid. Specs do not
have an explicit validation phase for them but they do specify the
limits so we'll have to add some clamping
Test:
imported/w3c/web-platform-tests/webxr/layers/xrEquirectLayer_paramValidation.https.html
*
LayoutTests/imported/w3c/web-platform-tests/webxr/layers/xrEquirectLayer_paramValidation.https-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/webxr/layers/xrEquirectLayer_paramValidation.https.html:
Added.
* Source/WebCore/Modules/webxr/XREquirectLayer.cpp:
(WebCore::XREquirectLayer::XREquirectLayer):
(WebCore::XREquirectLayer::setRadius):
(WebCore::XREquirectLayer::setCentralHorizontalAngle):
(WebCore::XREquirectLayer::setUpperVerticalAngle):
(WebCore::XREquirectLayer::setLowerVerticalAngle):
* Source/WebCore/Modules/webxr/XREquirectLayer.h:
(WebCore::XREquirectLayer::setRadius): Deleted.
(WebCore::XREquirectLayer::setCentralHorizontalAngle): Deleted.
(WebCore::XREquirectLayer::setUpperVerticalAngle): Deleted.
(WebCore::XREquirectLayer::setLowerVerticalAngle): Deleted.
Canonical link: https://commits.webkit.org/312595@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
