Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d2f180c1086767c5eb65c1778ae06da7d443ecfc
https://github.com/WebKit/WebKit/commit/d2f180c1086767c5eb65c1778ae06da7d443ecfc
Author: Philippe Normand <[email protected]>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
Log Message:
-----------
[GStreamer] Remove un-needed GstStreamVolume member variable from the media
player
https://bugs.webkit.org/show_bug.cgi?id=313886
Reviewed by Xabier Rodriguez-Calvar.
In our case the GstStreamVolume is the actual playbin(3) pipeline, for which we
already keep a
strong reference, so there's no need to have another reference for the
GstStreamVolume.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::tearDown):
(WebCore::MediaPlayerPrivateGStreamer::setVolumeDouble):
(WebCore::MediaPlayerPrivateGStreamer::volume const):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange):
(WebCore::MediaPlayerPrivateGStreamer::volumeChangedCallback):
(WebCore::MediaPlayerPrivateGStreamer::setMuted):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamer::muteChangedCallback):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::setStreamVolumeElement): Deleted.
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Canonical link: https://commits.webkit.org/312601@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
