Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 3d91767afa90035762b7dd74dfb3be97b3f15a0e
https://github.com/WebKit/WebKit/commit/3d91767afa90035762b7dd74dfb3be97b3f15a0e
Author: Sammy Gill <[email protected]>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
R
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-size-quirks-003-expected.html
R
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-size-quirks-003.html
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
Cherry-pick 310354@main (2f3d70f4c07f).
https://bugs.webkit.org/show_bug.cgi?id=311231
Unreviewed, reverting 310254@main (aeb2eadcea86)
https://bugs.webkit.org/show_bug.cgi?id=311231
rdar://173799843
REGRESSION(310254@main): bsky.app: Site content does not load, shows a spinner
only
Reverted change:
Zoom.com: Copy Invitation button is difficult to click.
https://bugs.webkit.org/show_bug.cgi?id=210791
rdar://170479667
310254@main (aeb2eadcea86)
Canonical link: https://commits.webkit.org/305877.474@webkitglib/2.52
Commit: 85e528121e3979c8a00b9336a6dfc25ac4a9f99b
https://github.com/WebKit/WebKit/commit/85e528121e3979c8a00b9336a6dfc25ac4a9f99b
Author: Sammy Gill <[email protected]>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
Cherry-pick 311739@main (d2d0e337b5fc).
https://bugs.webkit.org/show_bug.cgi?id=210791
[Attempt Two] Zoom.com: Copy Invitation button is difficult to click.
https://bugs.webkit.org/show_bug.cgi?id=210791
rdar://170479667
Reviewed by nobody.
In the in iteration of this fix we applied the new logic, which allowed
percent height descendants to resolve against ancestor flex items
depending on which phase of flex layout we are in, to work in both
standards in quirks mode. However, this ended up causing problems for
documents in standards mode even though the bug we were attempting to
fix was in quirks mode. So in this patch we can just make this fix more
scoped to only target documents in quirks mode.
Originally-landed-as: 310254@main (aeb2eadcea86). rdar://170479667
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flexItemHasPercentHeightDescendants const):
In some cases, percent height descendants can get registered on the
flexbox rather than the flex item. Before this patch, that meant
skipContainingBlockForPercentHeightCalculation would always return true
for those flex items. However, now we may get a different value for that
flex item depending on which phase of flex layout we are in. Instead, if
the flexbox has percent height descendants registered then we need to
always check if the flex item is the containing block for that
descendant.
Canonical link: https://commits.webkit.org/311739@main
Canonical link: https://commits.webkit.org/305877.475@webkitglib/2.52
Compare: https://github.com/WebKit/WebKit/compare/bd4109270ef1...85e528121e39
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
