Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: da96423634924bb1d0e6bd764918016ddef42f36
https://github.com/WebKit/WebKit/commit/da96423634924bb1d0e6bd764918016ddef42f36
Author: Ian Grunert <[email protected]>
Date: 2026-05-05 (Tue, 05 May 2026)
Changed paths:
A
LayoutTests/http/tests/IndexedDB/resources/stop-during-request-dispatch-frame.html
A
LayoutTests/http/tests/IndexedDB/transaction-stop-during-request-dispatch-expected.txt
A
LayoutTests/http/tests/IndexedDB/transaction-stop-during-request-dispatch.html
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
Log Message:
-----------
[Win] Handle in flight requests when IndexedDB stopped
https://bugs.webkit.org/show_bug.cgi?id=313931
Reviewed by Sihui Liu.
If a request was being completed when stop() was called, we weren't
explicitly cleaning it up and running it's completion handlers.
Test case transaction-stop-during-request-dispatch.html highlights the issue:
1. iframe issues 10 get requests, calls txn.commit(), sets onsuccess on the
first request
2. From inside firstGet.onsuccess, iframe postMessages the parent — this queues
the parent's onmessage task
3. Handler returns -> finishedDispatchEventForRequest clears
m_currentlyCompletingRequest, then handleOperationsCompletedOnServer
immediately sets it to get #1
4. Parent's onmessage (queued before step 3 finished) runs frame.remove() while
m_currentlyCompletingRequest = get #1
5. IDBTransaction::stop() runs with completion in flight — pre-fix path returns
early, retain cycle survives
Canonical link: https://commits.webkit.org/312647@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
