Title: [114807] trunk/Source
- Revision
- 114807
- Author
- dan...@chromium.org
- Date
- 2012-04-20 17:22:56 -0700 (Fri, 20 Apr 2012)
Log Message
[chromium] WebFilterOperations API does not compile or dynamically link
https://bugs.webkit.org/show_bug.cgi?id=84506
Reviewed by James Robinson.
Non-inline functions need WEBKIT_EXPORT in their declarations,
and the type used in the WebPrivateOwnPtr needs to be forward-
declared even when WEBKIT_IMPLEMENTATION is not defined.
Source/Platform:
* chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):
(WebFilterOperations):
Source/WebCore:
* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::initialize):
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (114806 => 114807)
--- trunk/Source/Platform/ChangeLog 2012-04-21 00:18:20 UTC (rev 114806)
+++ trunk/Source/Platform/ChangeLog 2012-04-21 00:22:56 UTC (rev 114807)
@@ -1,3 +1,18 @@
+2012-04-20 Dana Jansens <dan...@chromium.org>
+
+ [chromium] WebFilterOperations API does not compile or dynamically link
+ https://bugs.webkit.org/show_bug.cgi?id=84506
+
+ Reviewed by James Robinson.
+
+ Non-inline functions need WEBKIT_EXPORT in their declarations,
+ and the type used in the WebPrivateOwnPtr needs to be forward-
+ declared even when WEBKIT_IMPLEMENTATION is not defined.
+
+ * chromium/public/WebFilterOperations.h:
+ (WebKit::WebFilterOperations::WebFilterOperations):
+ (WebFilterOperations):
+
2012-04-20 James Robinson <jam...@chromium.org>
[chromium] Plumb a compositor surface ready notification through to the threaded compositor
Modified: trunk/Source/Platform/chromium/public/WebFilterOperations.h (114806 => 114807)
--- trunk/Source/Platform/chromium/public/WebFilterOperations.h 2012-04-21 00:18:20 UTC (rev 114806)
+++ trunk/Source/Platform/chromium/public/WebFilterOperations.h 2012-04-21 00:22:56 UTC (rev 114807)
@@ -29,11 +29,9 @@
#include "WebCommon.h"
#include "WebPrivateOwnPtr.h"
-#if WEBKIT_IMPLEMENTATION
namespace WebCore {
class FilterOperations;
}
-#endif
namespace WebKit {
struct WebFilterOperation;
@@ -41,18 +39,20 @@
// An ordered set of filter operations.
class WebFilterOperations {
public:
- WebFilterOperations();
+ WebFilterOperations() { initialize(); }
- void append(const WebFilterOperation&);
+ WEBKIT_EXPORT void append(const WebFilterOperation&);
// Removes all filter operations.
- void clear();
+ WEBKIT_EXPORT void clear();
#if WEBKIT_IMPLEMENTATION
const WebCore::FilterOperations& toFilterOperations() const;
#endif
private:
+ WEBKIT_EXPORT void initialize();
+
WebPrivateOwnPtr<WebCore::FilterOperations> m_private;
};
Modified: trunk/Source/WebCore/ChangeLog (114806 => 114807)
--- trunk/Source/WebCore/ChangeLog 2012-04-21 00:18:20 UTC (rev 114806)
+++ trunk/Source/WebCore/ChangeLog 2012-04-21 00:22:56 UTC (rev 114807)
@@ -1,3 +1,17 @@
+2012-04-20 Dana Jansens <dan...@chromium.org>
+
+ [chromium] WebFilterOperations API does not compile or dynamically link
+ https://bugs.webkit.org/show_bug.cgi?id=84506
+
+ Reviewed by James Robinson.
+
+ Non-inline functions need WEBKIT_EXPORT in their declarations,
+ and the type used in the WebPrivateOwnPtr needs to be forward-
+ declared even when WEBKIT_IMPLEMENTATION is not defined.
+
+ * platform/chromium/support/WebFilterOperations.cpp:
+ (WebKit::WebFilterOperations::initialize):
+
2012-04-20 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r114333.
Modified: trunk/Source/WebCore/platform/chromium/support/WebFilterOperations.cpp (114806 => 114807)
--- trunk/Source/WebCore/platform/chromium/support/WebFilterOperations.cpp 2012-04-21 00:18:20 UTC (rev 114806)
+++ trunk/Source/WebCore/platform/chromium/support/WebFilterOperations.cpp 2012-04-21 00:22:56 UTC (rev 114807)
@@ -35,7 +35,7 @@
namespace WebKit {
-WebFilterOperations::WebFilterOperations()
+void WebFilterOperations::initialize()
{
m_private.reset(new FilterOperations());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
