Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 95ea1fff522f22d45276eb6513749d75dff930ca
https://github.com/WebKit/WebKit/commit/95ea1fff522f22d45276eb6513749d75dff930ca
Author: Anthony Tarbinian <[email protected]>
Date: 2026-05-07 (Thu, 07 May 2026)
Changed paths:
M
LayoutTests/http/tests/contentextensions/block-everything-unless-domain.html
Log Message:
-----------
[Site Isolation]
http/tests/contentextensions/block-everything-unless-domain.html is flaky on
macOS post-commit bots
https://bugs.webkit.org/show_bug.cgi?id=314025
rdar://176216963
Reviewed by Sihui Liu.
https://commits.webkit.org/311882@main fixed
http/tests/contentextensions/block-everything-unless-domain.html
with site isolation enabled.
The test is not constantly failing, but is now flaky on macOS release
site-isolation post-commit bots
with the following diff:
```
---
/Volumes/Data/worker/Apple-Tahoe-Release-WK2-Site-Isolation-Tree-Tests/build/layout-test-results/http/tests/contentextensions/block-everything-unless-domain-expected.txt
+++
/Volumes/Data/worker/Apple-Tahoe-Release-WK2-Site-Isolation-Tree-Tests/build/layout-test-results/http/tests/contentextensions/block-everything-unless-domain-actual.txt
@@ -1,4 +1,3 @@
CONSOLE MESSAGE: helper loaded
-CONSOLE MESSAGE: Content blocker prevented frame displaying
http://localhost:8000/contentextensions/resources/should-not-load.html from
loading a resource from
http://localhost:8000/contentextensions/resources/should-not-load.html
CONSOLE MESSAGE: PASS - blocked the load
```
With site isolation enabled, the process swap for the popup window's navigation
from
127.0.0.1 to localhost can take longer than the test's 50ms polling window.
When this
happens, the test calls notifyDone() before the UIProcess has finished
processing the
provisional navigation failure, so the content blocker console message hasn't
arrived yet.
Fixed by replacing the polling loop with
testRunner.lastProvisionalNavigationFailureURL, which synchronously
queries the UIProcess for whether the navigation failure has been processed.
This test attempts to fix
http/tests/contentextensions/block-everything-unless-domain.html
with site isolation enabled
* LayoutTests/http/tests/contentextensions/block-everything-unless-domain.html:
Canonical link: https://commits.webkit.org/312807@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
