Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 78785f9d0600248b42aeb13ac4339f382b1f2856
https://github.com/WebKit/WebKit/commit/78785f9d0600248b42aeb13ac4339f382b1f2856
Author: Phinehas Fuachie <[email protected]>
Date: 2026-05-07 (Thu, 07 May 2026)
Changed paths:
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm
Log Message:
-----------
First hardware keypress ignored in video fullscreen on iPad with external
keyboard
https://bugs.webkit.org/show_bug.cgi?id=314177
rdar://146978555
Reviewed by Jer Noble.
AVFullScreenViewController delegates its keyCommands to AVPlayerViewController,
which gates them on
canControlPlayback (returns YES only when showsPlaybackControls is YES). WebKit
sets
showsPlaybackControls to NO during setup and only sets it back to YES in the
enterFullScreen
completion handler — after UIKit has already queried and cached keyCommands on
the new first
responder. The first keypress invalidates the stale cache, and the second
benefits from the fresh
query.
Fix by setting showsPlaybackControls to YES before calling
enterFullScreenAnimated:, so UIKit
caches a populated keyCommands array when AVFullScreenViewController becomes
first responder.
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm:
(-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]):
Canonical link: https://commits.webkit.org/312817@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
