Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ab0f27c1a2ade67fe625ab3770248fd681a5bedc
https://github.com/WebKit/WebKit/commit/ab0f27c1a2ade67fe625ab3770248fd681a5bedc
Author: Dewei Zhu <[email protected]>
Date: 2026-05-07 (Thu, 07 May 2026)
Changed paths:
M
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py
Log Message:
-----------
Fix a bug that run-benchmark may hang on exception while executed via SSH.
https://bugs.webkit.org/show_bug.cgi?id=314350
rdar://176494536
Reviewed by Yusuke Suzuki.
When run-benchmark launches Safari directly via its binary path, Safari inherits
the SSH session's pipe file descriptors. If the benchmark fails, Safari is
intentionally
left running for diagnosis (278420@main), but its inherited FDs prevent the SSH
session
from closing — causing the caller to hang until an external timeout kills it.
The fix
redirects Safari's stdin/stdout/stderr to DEVNULL since they are unused.
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver._launch_url_with_custom_path):
Canonical link: https://commits.webkit.org/312838@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
