Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5accc20f3107c735bd29c542ff8c15d1ee2550bc
https://github.com/WebKit/WebKit/commit/5accc20f3107c735bd29c542ff8c15d1ee2550bc
Author: Yusuke Suzuki <[email protected]>
Date: 2026-05-07 (Thu, 07 May 2026)
Changed paths:
M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
M Source/JavaScriptCore/llint/InPlaceInterpreter64.asm
M Source/JavaScriptCore/wasm/WasmCallee.cpp
M Source/JavaScriptCore/wasm/WasmCallee.h
M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.cpp
M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h
M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp
M Source/JavaScriptCore/wasm/WasmIPIntGenerator.h
M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp
M Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h
M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp
M Source/JavaScriptCore/wasm/WasmTypeDefinition.h
Log Message:
-----------
[JSC] Move aINT / mINT / uINT bytecode under RTT
https://bugs.webkit.org/show_bug.cgi?id=314133
rdar://176306252
Reviewed by Keith Miller.
We move aINT / mINT / uINT bytecode to RTT since they are tied to the signature.
This allows us to share them between calls with the same signature, and
also this offers an ability to lazily generate it when mINT is actually
used.
1. aINT / uINT are right now generated eagerly. This is similar to what
we have right now.
2. mINT is generated when a particular callsite encounters RTT and there
is no already registered bytecode. This becomes lazy generation, and
not happening until the callsite is actually used.
We save and restore MC in an unused slot before calls, which allows to
switch MC to pointing at shared bytecode instead of IPInt metadata.
We still have local bytecode which is used to initialize locals, but it
should be improved subsequently.
* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/llint/InPlaceInterpreter64.asm:
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::IPIntCallee::IPIntCallee):
* Source/JavaScriptCore/wasm/WasmCallee.h:
* Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.cpp:
(JSC::Wasm::FunctionIPIntMetadataGenerator::addReturnData): Deleted.
* Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h:
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::getCurrentInstructionLength):
(JSC::Wasm::IPIntGenerator::cachedCallInformationFor):
(JSC::Wasm::IPIntGenerator::addArguments):
(JSC::Wasm::IPIntGenerator::addLocal):
(JSC::Wasm::IPIntGenerator::addTailCallCommonData):
(JSC::Wasm::IPIntGenerator::addCall):
(JSC::Wasm::IPIntGenerator::addCallIndirect):
(JSC::Wasm::IPIntGenerator::addCallRef):
(JSC::Wasm::IPIntGenerator::finalize):
(JSC::Wasm::addCallArgumentBytecode): Deleted.
(JSC::Wasm::addCallResultBytecode): Deleted.
(JSC::Wasm::IPIntGenerator::addCallCommonData): Deleted.
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.h:
* Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp:
(JSC::Wasm::IPIntPlan::compileFunction):
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp:
(JSC::IPInt::ensureCallBytecodeForKind):
(JSC::IPInt::prepareCallImpl):
(JSC::IPInt::prepareCallIndirectImpl):
(JSC::IPInt::prepareCallRefImpl):
(JSC::IPInt::WASM_IPINT_EXTERN_CPP_DECL):
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h:
* Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp:
(JSC::Wasm::RTT::ensureArgumINTBytecode const):
(JSC::Wasm::RTT::ensureUINTBytecode const):
(JSC::Wasm::buildCallArgumentBytecode):
(JSC::Wasm::buildCallResultBytecode):
(JSC::Wasm::RTT::ensureCallBytecode const):
(JSC::Wasm::RTT::ensureTailCallBytecode const):
* Source/JavaScriptCore/wasm/WasmTypeDefinition.h:
Canonical link: https://commits.webkit.org/312841@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
