Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 89ee21a79a706b572a10ae80bc040b570003da4d
https://github.com/WebKit/WebKit/commit/89ee21a79a706b572a10ae80bc040b570003da4d
Author: Basuke Suzuki <[email protected]>
Date: 2026-05-07 (Thu, 07 May 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
[BFCache] Add diagnostic logging for goBack process selection and silent
navigation drop
https://bugs.webkit.org/show_bug.cgi?id=314236
rdar://176395564
Reviewed by Per Arne Vollan.
After a same-site BFCache navigation (hasSuspendedPage=0), pressing Back could
route goToBackForwardItem to the wrong WebProcess. The receiving process
silently
dropped the navigation, causing a permanent stall with no error logged.
Add RELEASE_LOG_ERROR at three diagnostic points:
1. When processForTheFrameItem selects a non-main-frame process for
goToBackForwardItem
2. When goBack/goToBackForwardItemAtIndex redirects from main frame to child
frame item
3. When WebPage::goToBackForwardItem drops navigation due to missing target
local frame
No new tests (logging-only change, covered by existing tests).
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::goToBackForwardItemAtIndex):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goToBackForwardItem):
Canonical link: https://commits.webkit.org/312855@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
