Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0f62ae09483d717d5ad8f6e1baeb6310957fc9fd
https://github.com/WebKit/WebKit/commit/0f62ae09483d717d5ad8f6e1baeb6310957fc9fd
Author: Charlie Wolfe <[email protected]>
Date: 2026-05-08 (Fri, 08 May 2026)
Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/Modules/permissions/PermissionStatus.cpp
Log Message:
-----------
imported/w3c/web-platform-tests/storage-access-api/storage-access-permission.sub.https.window.html
is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=314377
rdar://176532878
Reviewed by Pascoe.
PermissionStatus::eventListenersDidChange() used callOnMainThread to register
the storage-access
permission change subscription with the NetworkProcess. Since callOnMainThread
always defers to the
next run loop iteration—even when already on the main thread—there was a window
where a subsequent
test_driver.set_permission call could reach the NetworkProcess before the
subscription was
registered, causing the change notification to be silently dropped.
Replace callOnMainThread with ensureOnMainThread, which executes synchronously
when already on the
main thread. This matches the pattern already used in the PermissionStatus
constructor.
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/Modules/permissions/PermissionStatus.cpp:
(WebCore::PermissionStatus::eventListenersDidChange):
Canonical link: https://commits.webkit.org/312917@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
