Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1935c806544bce00affa95f3e23fdddcfd94dcb5
https://github.com/WebKit/WebKit/commit/1935c806544bce00affa95f3e23fdddcfd94dcb5
Author: Alan Baradlay <[email protected]>
Date: 2026-05-10 (Sun, 10 May 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderWidget.cpp
M Source/WebCore/rendering/svg/RenderSVGRoot.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp
Log Message:
-----------
Rename aspect ratio helpers on RenderReplaced and RenderBox
https://bugs.webkit.org/show_bug.cgi?id=314460
Reviewed by Antti Koivisto.
- Remove computeIntrinsicAspectRatio() - it was just
preferredAspectRatio().aspectRatioDouble().
- Rename resolveAspectRatio() to aspectRatioValue() - it does not resolve
anything, just returns the applicable ratio as a double.
- Rename isRenderReplacedWithIntrinsicRatio() to
isReplacedWithPreferredAspectRatio() - clearer about what it checks.
- Restore shouldApplySizeOrInlineSizeContainment
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalMinMaxSizesByAspectRatio const):
(WebCore::RenderBox::computeIntrinsicKeywordLogicalWidths const):
(WebCore::RenderBox::isReplacedWithPreferredAspectRatio const):
(WebCore::RenderBox::aspectRatioValue const):
(WebCore::RenderBox::computeMinMaxLogicalWidthFromAspectRatio const):
(WebCore::RenderBox::computeMinMaxLogicalHeightFromAspectRatio const):
(WebCore::RenderBox::isRenderReplacedWithIntrinsicRatio const): Deleted.
(WebCore::RenderBox::resolveAspectRatio const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::isSVGRootWithIntrinsicAspectRatio):
(WebCore::RenderFlexibleBox::preferredAspectRatioForFlexItem const):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::computeIntrinsicSize const):
(WebCore::RenderImage::preferredAspectRatio const):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioAdjustedIntrinsicLogicalWidths
const):
(WebCore::RenderReplaced::computeIntrinsicKeywordLogicalWidths const):
(WebCore::RenderReplaced::computeIntrinsicAspectRatio const): Deleted.
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::computeIntrinsicSize const):
(WebCore::RenderWidget::preferredAspectRatio const):
* Source/WebCore/rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::hasIntrinsicAspectRatio const):
(WebCore::RenderSVGRoot::computeIntrinsicSize const):
(WebCore::RenderSVGRoot::preferredAspectRatio const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::hasIntrinsicAspectRatio const):
(WebCore::LegacyRenderSVGRoot::computeIntrinsicSize const):
(WebCore::LegacyRenderSVGRoot::preferredAspectRatio const):
Canonical link: https://commits.webkit.org/312974@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
