Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 98e7cf381a18ab0c199b60d12492f0cd69afd6f5
https://github.com/WebKit/WebKit/commit/98e7cf381a18ab0c199b60d12492f0cd69afd6f5
Author: Alan Baradlay <[email protected]>
Date: 2026-05-10 (Sun, 10 May 2026)
Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
Log Message:
-----------
[cleanup] Clean up aspect ratio naming: remove computeIntrinsicAspectRatio,
intrinsicRatio, isRenderReplacedWithIntrinsicRatio and rename resolveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=314479
Reviewed by Antti Koivisto.
- computeIntrinsicAspectRatio() was just
preferredAspectRatio().aspectRatioDouble().
- intrinsicRatio() was just preferredAspectRatio(). Callers now use
preferredAspectRatio() directly. Removed.
- resolveAspectRatio() renamed to aspectRatioValue() - it just returns the
applicable ratio as a double, no resolution involved.
- isRenderReplacedWithIntrinsicRatio converted to a file-local static helper
(replacedPreferredAspectRatio) and then inlined into its only ASSERT caller.
- RenderBox::computeIntrinsicKeywordLogicalWidths refactored to use early
returns.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalMinMaxSizesByAspectRatio const):
(WebCore::RenderBox::computeIntrinsicKeywordLogicalWidths const):
(WebCore::RenderBox::computeSizingKeywordLogicalContentHeightUsingGeneric
const):
(WebCore::RenderBox::isReplacedWithPreferredAspectRatio const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::intrinsicRatio const): Deleted.
* Source/WebCore/rendering/RenderReplaced.h:
Canonical link: https://commits.webkit.org/312977@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
