Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cdc76f4dc73b5560c0293c10dd3cff23e9626575
https://github.com/WebKit/WebKit/commit/cdc76f4dc73b5560c0293c10dd3cff23e9626575
Author: Zak Ridouh <[email protected]>
Date: 2026-05-11 (Mon, 11 May 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformMac.cmake
Log Message:
-----------
[CMake] TestWebKitAPI on Mac doesn't bundle nested resource directories
https://bugs.webkit.org/show_bug.cgi?id=314595
rdar://176834169
Reviewed by BJ Burg and Geoffrey Garen.
The previous resource staging in PlatformMac.cmake used file(GLOB) with the
pattern `*.*` to copy Resources/ and Resources/cocoa/ flat into
TestWebKitAPIResources.bundle. This missed:
- Files in nested subdirectories under Resources/cocoa/, including
web-extension/, web-extension-{ios,mac}.appex/, and
TestModalContainerControls.mlmodelc/.
- Top-level files whose names contain no dot (e.g.
Resources/cocoa/invalidDeviceIDHashSalts).
Tests that load a directory as a bundle via -[NSBundle
URLForResource:withExtension:]
(WKWebExtension.LoadFromDirectory, LoadFrom{Mac,iOS}AppExtensionBundle) failed
to find their resources. GetUserMedia.InvalidDeviceIdHashSalts also failed for
the dotless-filename reason.
Replace the flat WEBKIT_COPY_FILES call with a small helper that uses
file(GLOB_RECURSE) and emits one create_symlink command per file, preserving
the relative path under each source root. The cocoa/ prefix is stripped so
URLForResource: lookups continue to work, and Resources/glib/ is skipped on
the Mac port.
* Tools/TestWebKitAPI/PlatformMac.cmake:
Canonical link: https://commits.webkit.org/313044@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
