Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d2bbeb82975126c7c8bfc7933f867e3811b25793
https://github.com/WebKit/WebKit/commit/d2bbeb82975126c7c8bfc7933f867e3811b25793
Author: Timothy Hatcher <[email protected]>
Date: 2026-05-11 (Mon, 11 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPIRuntime.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPIStorage.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPITabs.mm
Log Message:
-----------
REGRESSION(285929@main-285928@main): [ iOS Debug ] WKWebExtensionAPI* tests
are flaky timeout.
https://webkit.org/b/290403
rdar://problem/147858640
Reviewed by Brian Weinstein.
Replace setTimeout-based synchronization in web extension tests with explicit
`browser.test.sendMessage` /
`runUntilTestMessage` handshakes. These older tests were written before that
pattern was established
and never got updated, causing intermittent failures on both macOS and iOS
where the 1–2 second delays
were insufficient to guarantee the background script was ready before a tab URL
was loaded.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPIRuntime.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, ConnectFromContentScript)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime,
ConnectFromContentScriptWithMultipleListeners)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime,
PortDisconnectFromContentScript)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime,
PortDisconnectFromContentScriptWithMultipleListeners)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, ConnectFromWebPage)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime,
ConnectFromWebPageWithImmediateMessage)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime, SendMessageFromWebPage)):
(TestWebKitAPI::TEST(WKWebExtensionAPIRuntime,
SendMessageFromWebPageWithTabFrameAndAsyncReply)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPIStorage.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIStorage, SetAccessLevelTrustedContexts)):
(TestWebKitAPI::TEST(WKWebExtensionAPIStorage,
SetAccessLevelTrustedAndUntrustedContexts)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessage)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageWithAsyncReply)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageWithPromiseReply)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageWithAsyncPromiseReply)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, SendMessageWithoutReply)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs,
SendMessageFromBackgroundToSubframe)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, Connect)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, ConnectToSubframe)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, PortDisconnect)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs, ConnectWithMultipleListeners)):
(TestWebKitAPI::TEST(WKWebExtensionAPITabs,
PortDisconnectWithMultipleListeners)):
Canonical link: https://commits.webkit.org/313046@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
