Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f0276e0b14b798fac70f9d5f9e8d3f4fedb17813
https://github.com/WebKit/WebKit/commit/f0276e0b14b798fac70f9d5f9e8d3f4fedb17813
Author: Richard Robinson <[email protected]>
Date: 2026-05-11 (Mon, 11 May 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.h
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
M Source/WebKit/UIProcess/mac/WKTextSelectionController.swift
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
Log Message:
-----------
[AppKit Gestures]
AppKitGesturesTests.doubleClickingInWordSelectsWord(contentEditable:clickHandler:)
test is failing
https://bugs.webkit.org/show_bug.cgi?id=314591
rdar://176821429
Reviewed by Abrar Rahman Protyasha.
Widen the fix that was previously done with `cancelClick` to instead be a
scoped suppression mechanism
to stop and suppress clicks generated by both the single click GR or the mouse
tracking GR.
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.h:
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController
beginSuppressingSingleClickGestureForTextSelection]):
(-[WKAppKitGestureController endSuppressingSingleClickGestureForTextSelection]):
(-[WKAppKitGestureController mouseTrackingGestureRecognized:]):
(-[WKAppKitGestureController _handleClickBegan:]):
(-[WKAppKitGestureController reset]):
(-[WKAppKitGestureController cancelClick]): Deleted.
* Source/WebKit/UIProcess/mac/WKTextSelectionController.swift:
(WKTextSelectionController.moveInsertionCursor(to:placeAtWordBoundary:)):
(WKTextSelectionController.beginRangeSelection(at:with:)):
(WKTextSelectionController.endRangeSelection(at:)):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::beginSuppressingSingleClickGestureForTextSelection):
(WebKit::WebViewImpl::endSuppressingSingleClickGestureForTextSelection):
(WebKit::WebViewImpl::cancelClick): Deleted.
Canonical link: https://commits.webkit.org/313054@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
