Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 46f5d284a13d5f286b9d68fc66e0ce29164352f2
https://github.com/WebKit/WebKit/commit/46f5d284a13d5f286b9d68fc66e0ce29164352f2
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
M
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm
M
Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProvokingVertexHelper.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_pool.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_pool.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.mm
M Source/ThirdParty/ANGLE/src/tests/gl_tests/BufferPoolTestMetal.mm
Log Message:
-----------
ANGLE: Metal: Avoid using pointers in BufferPool::allocate
https://bugs.webkit.org/show_bug.cgi?id=314181
rdar://176343541
Reviewed by Dan Glastonbury.
Use angle::Span<uint8_t> instead of uint8_t* for mapping out the
allocated buffer slice.
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:
(rx::ConversionBufferMtl::ConversionBufferMtl):
(rx::BufferMtl::getVertexConversionBuffer):
(rx::BufferMtl::markConversionBuffersDirty):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm:
(rx::ProgramExecutableMtl::commitUniforms):
(rx::ProgramExecutableMtl::legalizeUniformBufferOffsets):
(rx::ProgramExecutableMtl::encodeUniformBuffersInfoArgumentBuffer):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProvokingVertexHelper.mm:
(rx::ProvokingVertexHelper::preconditionIndexBuffer):
(rx::ProvokingVertexHelper::generateIndexBuffer):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm:
(rx::VertexArrayMtl::updateClientAttribs):
(rx::VertexArrayMtl::convertIndexBuffer):
(rx::VertexArrayMtl::streamIndexBufferFromClient):
(rx::VertexArrayMtl::convertVertexBuffer):
(rx::VertexArrayMtl::convertVertexBufferCPU):
(rx::VertexArrayMtl::convertVertexBufferGPU):
(rx::VertexArrayMtl::convertIndexBufferGPU): Deleted.
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_pool.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_pool.mm:
(rx::mtl::BufferPool::allocate):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.mm:
(rx::mtl::RenderUtils::convertIndexBufferGPU):
(rx::mtl::IndexGeneratorUtils::convertIndexBufferGPU):
* Source/ThirdParty/ANGLE/src/tests/gl_tests/BufferPoolTestMetal.mm:
(angle::TEST_P):
Canonical link: https://commits.webkit.org/313076@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
