Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b8f7b64ba81ecd34c0070b2da6222ab1fe37cb8a
https://github.com/WebKit/WebKit/commit/b8f7b64ba81ecd34c0070b2da6222ab1fe37cb8a
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKAttachmentTests.mm
Log Message:
-----------
WKAttachmentTestsMac.DraggingAttachmentBackedImagePreservesRangedSelection is
a constant failure in some configurations
https://bugs.webkit.org/show_bug.cgi?id=314601
rdar://176587027
Reviewed by Richard Robinson.
The test was stuck because mouseDragToPoint: triggers an AppKit drag
session whose modal loop blocks on [NSApp nextEventMatchingMask:...],
but the mouseUpAtPoint: helper uses [NSWindow sendEvent:], which goes
straight to the view (bypassing the event queue).
To fix this issue, we post a mouseUp event to the NSApp event queue so
the drag loop can terminate.
This mirrors the established pattern in Pasteboard::setDragImage (WK1) of
posting events to wake NSDragManager out of its nextEvent call. Note
that this is not necessary in product code becase WindowServer
continuously feeds the app's event queue. When the user releases the
mouse, a real mouseUp arrives in the queue and the drag loop picks it up
naturally.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKAttachmentTests.mm:
(TestWebKitAPI::TEST(WKAttachmentTestsMac,
DraggingAttachmentBackedImagePreservesRangedSelection)):
Canonical link: https://commits.webkit.org/313084@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
