Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 32f3f6f4b35f6eafedcb59db14d252c2662e07d3
https://github.com/WebKit/WebKit/commit/32f3f6f4b35f6eafedcb59db14d252c2662e07d3
Author: Geoffrey Garen <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M Source/WebCore/PlatformMac.cmake
M Source/WebCore/testing/MockParentalControlsURLFilter.h
M Source/WebKit/PlatformMac.cmake
M Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.cpp
M Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.h
M Source/WebKit/UIProcess/PageClient.cpp
M Source/WebKit/UIProcess/PageClient.h
Log Message:
-----------
[CMake] REGRESSION: WebKitTestRunner crashes on launch with a linker error
https://bugs.webkit.org/show_bug.cgi?id=314640
rdar://176881806
Reviewed by Charlie Wolfe, Pascoe, and David Kilzer.
* Source/WebCore/PlatformMac.cmake: Compile MockParentalControlsURLFilter.mm
as a part of WebCore to match the Xcode build and put the linked symbol
where the rest of the project expects it. (It's not ideal to pull a TestSupport
symbol out of the TestSupport list, but for now it's easiest to maintain if
the build systems match each other bug-for-bug.)
* Source/WebCore/testing/MockParentalControlsURLFilter.h: Use WEBCORE_EXPORT
because this file is in the WebCore file list now.
* Source/WebKit/PlatformMac.cmake: Do real linking at compile time, so that we
catch bugs like this eagerly in the future.
* Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.cpp:
(WebKit::DisplayLinkProcessProxyClient::DisplayLinkProcessProxyClient):
* Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.h:
* Source/WebKit/UIProcess/PageClient.cpp:
(WebKit::PageClient::PageClient):
* Source/WebKit/UIProcess/PageClient.h: Added ClangVTableWorkaroundTag for the
two classes that triggered the clang vtable linking bug.
Canonical link: https://commits.webkit.org/313089@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
