Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: afb06760e1c5a47d1953a8e37d93383c5c970490
https://github.com/WebKit/WebKit/commit/afb06760e1c5a47d1953a8e37d93383c5c970490
Author: Charlie Wolfe <[email protected]>
Date: 2026-05-12 (Tue, 12 May 2026)
Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Source/WebCore/page/Frame.h
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/RemoteFrame.cpp
M Source/WebCore/page/RemoteFrame.h
M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
Log Message:
-----------
[Site Isolation]
`imported/w3c/web-platform-tests/storage-access-api/requestStorageAccess-web-socket.sub.https.window.html`
fails
https://bugs.webkit.org/show_bug.cgi?id=314602
rdar://176845704
Reviewed by Sihui Liu.
WebSocketChannel was accessing the local main frame's document loader to read
allowPrivacyProxy,
which doesn't work with site isolation when the main frame is remote. Add
allowPrivacyProxy as a
virtual method on Frame, propagate it through WebsitePoliciesData to
RemoteFrame, and change
WebSocketChannel::connect to access the frame tree in a way that works with
site isolation.
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/WebCore/page/Frame.h:
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::allowPrivacyProxy const):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/RemoteFrame.cpp:
(WebCore::RemoteFrame::allowPrivacyProxy const):
* Source/WebCore/page/RemoteFrame.h:
* Source/WebKit/WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::connect):
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::applyWebsitePolicies):
Canonical link: https://commits.webkit.org/313097@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
