Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ae2ef22d44ed6734cd09938021681f5732ac8d87
https://github.com/WebKit/WebKit/commit/ae2ef22d44ed6734cd09938021681f5732ac8d87
Author: Anne van Kesteren <[email protected]>
Date: 2026-05-17 (Sun, 17 May 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/fs/FileSystemBaseHandle-isSameEntry.https.any.worker-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-isSameEntry.js
M Source/WebCore/Modules/filesystem/FileSystemHandle.cpp
Log Message:
-----------
FileSystemHandle: isSameEntry() needs to call ensureIdentifier() on both
handles
https://bugs.webkit.org/show_bug.cgi?id=314973
Reviewed by Sihui Liu.
isSameEntry only called ensureIdentifier on `this`; the other handle's
m_identifier was assumed to already be set. That assumption holds when
the handle was created via getFileHandle / getDirectoryHandle, since
the WebProcess gets a FileSystemHandleIdentifier as part of the
roundtrip. It does not hold for a handle that was deserialized from
postMessage / structuredClone: the deserializer constructs the handle
with an empty Markable<FileSystemHandleIdentifier> and calls
markAsUnresolved, so handle->identifier() (which is *m_identifier)
release-asserts in Markable.h.
Test:
imported/w3c/web-platform-tests/fs/script-tests/FileSystemBaseHandle-isSameEntry.js
Upstream: https://github.com/web-platform-tests/wpt/pull/59933
Canonical link: https://commits.webkit.org/313396@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
