Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e3b3680f8792895e4744a36c6f7468cdc757e657
https://github.com/WebKit/WebKit/commit/e3b3680f8792895e4744a36c6f7468cdc757e657
Author: Zak Ridouh <[email protected]>
Date: 2026-05-19 (Tue, 19 May 2026)
Changed paths:
M Tools/TestWebKitAPI/PlatformMac.cmake
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ClearWrappersNavigatePlugIn.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ContentFilteringPlugIn.mm
Log Message:
-----------
[CMake] Compile per-test plug-in classes into TestWebKitAPI.wkbundle
https://bugs.webkit.org/show_bug.cgi?id=315067
rdar://177396182
Reviewed by Pascoe.
The TestWebKitAPIWebProcessPlugIn target previously compiled only the bundle
trampoline and WebProcessPlugInWithInternals, so tests calling
_test_configurationWithTestPlugInClassName: hit nil from NSClassFromString.
Add the per-test plug-in classes from the Xcode WebProcessPlugIn target's
membershipExceptions list. Five files are dual-membership with TestWebKit;
since WEBKIT_COMPUTE_SOURCES marks their originals HEADER_FILE_ONLY, build
them here via generated #include shims. Extend the include path with
Tests/WebKit/WKWebView and WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR.
Add the missing direct imports to ClearWrappersNavigatePlugIn.mm
(<wtf/RetainPtr.h>) and ContentFilteringPlugIn.mm
(<WebCore/PlatformExportMacros.h>);
both were relying on the prefix-header / BUILDING_TestWebKit config path that
the bundle target doesn't go through.
* Tools/TestWebKitAPI/PlatformMac.cmake:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ClearWrappersNavigatePlugIn.mm:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ContentFilteringPlugIn.mm:
Canonical link: https://commits.webkit.org/313519@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
