Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5c9c77898e538f04f03c5579bf8f36cfb227cb6a
https://github.com/WebKit/WebKit/commit/5c9c77898e538f04f03c5579bf8f36cfb227cb6a
Author: Zak Ridouh <[email protected]>
Date: 2026-05-19 (Tue, 19 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/config.py
M Tools/Scripts/webkitpy/port/config_unittest.py
M Tools/Scripts/webkitpy/port/factory.py
Log Message:
-----------
[CMake] Teach run-api-tests to find CMake built binaries with --cmake
https://bugs.webkit.org/show_bug.cgi?id=314938
rdar://177224796
Reviewed by Pascoe.
Tools/Scripts/run-api-tests had no way to target a CMake build tree.
Passing --cmake exited with "no such option", and Config.build_directory()
never forwarded --cmake to webkit-build-directory anyway, so paths always
resolved to the Xcode build products.
Add --cmake to configuration_options(), and thread it through Port
into Config, and append it to the webkit-build-directory invocation.
For example, now `run-api-tests --cmake --debug` will resolve binaries
out of WebKitBuild/cmake-mac/Debug/ (the mac-debug / mac-dev-debug
preset output) instead of WebKitBuild/Debug/.
* Tools/Scripts/webkitpy/port/base.py:
(Port.__init__):
* Tools/Scripts/webkitpy/port/config.py:
(Config.__init__):
(Config.build_directory):
* Tools/Scripts/webkitpy/port/config_unittest.py:
(ConfigTest.make_config):
(ConfigTest.test_build_directory_passes_cmake_flag):
(ConfigTest.test_build_directory_passes_cmake_flag.mock_run_command):
* Tools/Scripts/webkitpy/port/factory.py:
(configuration_options):
Canonical link: https://commits.webkit.org/313522@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
