Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 62cd2f0590242948b4ff294d856ce2cf877777ab
https://github.com/WebKit/WebKit/commit/62cd2f0590242948b4ff294d856ce2cf877777ab
Author: Zak Ridouh <[email protected]>
Date: 2026-05-20 (Wed, 20 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/base.py
Log Message:
-----------
[CMake] Forward --cmake from run-minibrowser/run-swiftbrowser to underlying
perl scripts
https://bugs.webkit.org/show_bug.cgi?id=315248
rdar://177574770
Reviewed by Alan Baradlay.
Follow-up to 313522@main, which added --cmake to configuration_options()
but didn't thread it through Port.run_minibrowser() / Port.run_swiftbrowser().
As a result, `run-minibrowser --debug --cmake` accepted the flag at the
Python layer but never passed it to old-run-minibrowser, so webkitdirs.pm
fell back to the Xcode build tree and the launch failed to find the
CMake-built MiniBrowser.
Append --cmake to the args passed to old-run-minibrowser and
run-swiftbrowser-perl-wrapper when the option is set, matching how
--<platform> and --<configuration> are already forwarded.
* Tools/Scripts/webkitpy/port/base.py:
(Port.run_minibrowser):
(Port.run_swiftbrowser):
Canonical link: https://commits.webkit.org/313629@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
