Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 957217590013d8e07d5ee2f6bcf1a8be37aa86a5
https://github.com/WebKit/WebKit/commit/957217590013d8e07d5ee2f6bcf1a8be37aa86a5
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
A .wkdev-sdk-version
M Tools/Scripts/browserperfdash-benchmark
M Tools/Scripts/build-webkit
A Tools/Scripts/container-sdk-autoenter
M Tools/Scripts/generate-bundle
M Tools/Scripts/install-built-product
M Tools/Scripts/run-api-tests
M Tools/Scripts/run-bindings-tests
M Tools/Scripts/run-builtins-generator-tests
M Tools/Scripts/run-css-property-code-generation-tests
M Tools/Scripts/run-gtk-tests
M Tools/Scripts/run-javascriptcore-tests
M Tools/Scripts/run-minibrowser
M Tools/Scripts/run-perf-tests
M Tools/Scripts/run-qt-wpe-minibrowser
M Tools/Scripts/run-webdriver
M Tools/Scripts/run-webdriver-tests
M Tools/Scripts/run-webkit-httpd
M Tools/Scripts/run-webkit-tests
M Tools/Scripts/run-wpe-tests
M Tools/Scripts/test-bundle
M Tools/Scripts/test-webkitperl
M Tools/Scripts/test-webkitpy
M Tools/Scripts/test262-runner
M Tools/Scripts/update-webkitgtk-libs
M Tools/Scripts/update-webkitwpe-libs
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
M Tools/Scripts/webkitpy/style/checker.py
M Tools/Scripts/webkitpy/style/checkers/common.py
M Tools/glib/run-webkit-app.py
Log Message:
-----------
Cherry-pick 313201@main (282e85933b5f).
https://bugs.webkit.org/show_bug.cgi?id=314546
[GTK][WPE][Tools] Auto-enter WebKit Container SDK from host wrappers
https://bugs.webkit.org/show_bug.cgi?id=314546
Reviewed by Carlos Alberto Lopez Perez.
Add .wkdev-sdk-version at the repo root pinning the wkdev-sdk image
version, and teach the WebKit wrapper scripts (build-webkit,
run-webkit-tests, run-api-tests, run-minibrowser, run-{gtk,wpe}-tests
plus the rest of the bot-relevant wrappers listed below, including
update-webkit{gtk,wpe}-libs) to relaunch themselves inside a
'wkdev-build' container when invoked on the host. The container is
auto-created with `podman create` on first use, pulling
ghcr.io/igalia/wkdev-sdk:<pinned> from the registry. Host CWD under
$HOME is translated to /host/home/$USER and passed as --workdir so
relative paths keep working.
Auto-enter is opt-in: set WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER=1 to
turn it on (e.g. on the bots, or in a developer shell). Without that
flag the wrappers run on the host exactly as before.
Container layout:
* image: ghcr.io/igalia/wkdev-sdk:<pinned-version>
* command: sleep infinity (image has no ENTRYPOINT)
* home dir: $HOME/wkdev-build (host) -> /home/$USER (container)
* host home: $HOME (host) -> /host/home/$USER (container)
* userns: keep-id; per-exec --user $UID:$GID
* namespaces: --pid host --ipc host --network host
* mounts: /etc/{hosts,localtime,resolv.conf,machine-id}, /dev,
/run/udev,
/dev/dri, NVIDIA CDI (when present), /tmp/.X11-unix, audio
(PULSE_SERVER or $XDG_RUNTIME_DIR/pulse), session and system
DBus buses, accessibility (at-spi), dconf, $XDG_RUNTIME_DIR
exposed as /host/run (for Wayland/PipeWire socket symlinks)
Deliberately NOT mounted: nested podman.sock, SSH keyring, systemd journal,
coredumps, themes/icons/fonts. No --cap-add flags (needed for
profiling/gdb/etc.).
First-run init runs once after `podman create` as root inside the
container: creates /run/user/$UID with the right perms, chowns
/jhbuild /opt/rust /sdk to the host UID, and marks /run/.wkdev-init-done.
The set of host env vars forwarded into the container mirrors what the
Flatpak SDK has been forwarding (see Tools/flatpak/flatpakutils.py's
env_var_{prefixes,suffixes}_to_keep / env_vars_to_keep) and adds the
GST_* prefix. WEBKIT_CONTAINER_SDK* internal flags are never forwarded.
When invoked on the host and the existing 'wkdev-build' container's
image does not match the pinned version, the container is stopped,
removed and recreated. The container home directory survives; ad-hoc
filesystem changes inside the container do not.
If 'podman' is not on $PATH the helpers print a prominent warning
pointing at https://github.com/Igalia/webkit-container-sdk and continue
on the host (auto-launch disabled).
When already inside a wkdev-sdk container the running SDK version (from
/etc/wkdev-sdk-version baked into the image) is compared against the
pinned one; on mismatch a prominent warning suggests re-running any
wrapper from the host to recreate the container, but execution continues.
The plan is to use that new mode on the bots to guarantee a certain SDK
image is used -- it also allows us to switch the used SDK image in a PR
that runs through EWS.
* .wkdev-sdk-version: Added.
* Tools/Scripts/browserperfdash-benchmark:
* Tools/Scripts/build-webkit:
* Tools/Scripts/container-sdk-autoenter: Copied from
Tools/Scripts/browserperfdash-benchmark.
* Tools/Scripts/generate-bundle:
* Tools/Scripts/install-built-product:
* Tools/Scripts/run-api-tests:
* Tools/Scripts/run-bindings-tests:
* Tools/Scripts/run-builtins-generator-tests:
* Tools/Scripts/run-css-property-code-generation-tests:
* Tools/Scripts/run-gtk-tests:
* Tools/Scripts/run-javascriptcore-tests:
* Tools/Scripts/run-minibrowser:
* Tools/Scripts/run-perf-tests:
* Tools/Scripts/run-qt-wpe-minibrowser:
* Tools/Scripts/run-webdriver:
* Tools/Scripts/run-webdriver-tests:
* Tools/Scripts/run-webkit-httpd:
* Tools/Scripts/run-webkit-tests:
* Tools/Scripts/run-wpe-tests:
* Tools/Scripts/test-bundle:
* Tools/Scripts/test-webkitperl:
* Tools/Scripts/test-webkitpy:
* Tools/Scripts/test262-runner:
* Tools/Scripts/update-webkitgtk-libs:
* Tools/Scripts/update-webkitwpe-libs:
* Tools/Scripts/webkitdirs.pm:
(maybeEnterWebKitContainerSDK):
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_env_var_should_be_forwarded):
(_print_prominent_warning):
(_read_first_line_of):
(_read_running_sdk_version):
(_source_dir):
(_read_pinned_sdk_version):
(_strip_unix_path_prefix):
(_translate_host_path_to_container):
(_podman_container_info):
(_xdg_runtime_dir):
(_xdg_config_home):
(_container_home_path):
(_bind_mount):
(_build_podman_create_args):
(_init_and_sync_container_runtime):
(_stop_and_remove_container):
(_create_container):
(_ensure_container_ready):
(maybe_enter_webkit_container_sdk):
(maybe_use_container_sdk_root_dir):
* Tools/Scripts/webkitpy/style/checker.py:
* Tools/Scripts/webkitpy/style/checkers/common.py:
* Tools/glib/run-webkit-app.py:
Canonical link: https://commits.webkit.org/313201@main
Canonical link: https://commits.webkit.org/305877.635@webkitglib/2.52
Commit: 825025bd52f11a725eafdaa4b72dfe532896c6fa
https://github.com/WebKit/WebKit/commit/825025bd52f11a725eafdaa4b72dfe532896c6fa
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M .wkdev-sdk-version
Log Message:
-----------
Cherry-pick 313227@main (eaeb5476a97e).
https://bugs.webkit.org/show_bug.cgi?id=314797
[GTK][WPE] Update pinned wkdev-sdk container version
https://bugs.webkit.org/show_bug.cgi?id=314797
Reviewed by Claudio Saavedra.
Bump required wkdev-sdk version.
* .wkdev-sdk-version:
Canonical link: https://commits.webkit.org/313227@main
Canonical link: https://commits.webkit.org/305877.636@webkitglib/2.52
Commit: ca87ba6dd26426c1a8d46ead762ef96f136ebee8
https://github.com/WebKit/WebKit/commit/ca87ba6dd26426c1a8d46ead762ef96f136ebee8
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M .wkdev-sdk-version
Log Message:
-----------
Cherry-pick 313305@main (1ecdb611c3a9).
https://bugs.webkit.org/show_bug.cgi?id=314889
[GTK][WPE] Bump SDK version from 2.53-v3-bf0ef5d -> 2.53-v4-95ead24
https://bugs.webkit.org/show_bug.cgi?id=314889
Reviewed by Carlos Alberto Lopez Perez.
Switch to latest SDK version. No functional changes, only tooling
improvments.
* .wkdev-sdk-version:
Canonical link: https://commits.webkit.org/313305@main
Canonical link: https://commits.webkit.org/305877.637@webkitglib/2.52
Commit: a279c6678ddbc5a5895efce3a70bb18fe2203b62
https://github.com/WebKit/WebKit/commit/a279c6678ddbc5a5895efce3a70bb18fe2203b62
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
Cherry-pick 313228@main (6bebe6dfcd60).
https://bugs.webkit.org/show_bug.cgi?id=314800
[GTK][WPE] Always warn on wkdev-sdk container version mismatch, regardless
of auto-enter
https://bugs.webkit.org/show_bug.cgi?id=314800
Reviewed by Claudio Saavedra.
The version-mismatch warning in maybe_enter_webkit_container_sdk()
previously
fired only when WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER=1, and never at all
from
Perl wrappers (build-webkit, run-javascriptcore-tests, ...) because their
fast-
path mirror in webkitdirs.pm short-circuited when WEBKIT_CONTAINER_SDK==1.
As
a result, a developer running an outdated wkdev-sdk container without
auto-enter
got no signal that their container had drifted from .wkdev-sdk-version.
Reorder the Python helper so the in-container version-mismatch check runs
before the auto-enter opt-in gate (only host-side auto-enter remains gated
on
WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER and WEBKIT_CROSS_TARGET). Update the
Perl
mirror so it invokes the helper when inside the container regardless of
opt-in,
keeping the host-side opt-out as the only fast-path skip.
Canonical link: https://commits.webkit.org/313228@main
Canonical link: https://commits.webkit.org/305877.638@webkitglib/2.52
Commit: 2daaed498c79062fe6ad381c8df6ef445b79ba91
https://github.com/WebKit/WebKit/commit/2daaed498c79062fe6ad381c8df6ef445b79ba91
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
Cherry-pick 313232@main (e67bead77ea1).
https://bugs.webkit.org/show_bug.cgi?id=314805
[GTK][WPE] Drop --pid host from wkdev-build container creation
https://bugs.webkit.org/show_bug.cgi?id=314805
Unreviewed build fix
The auto-enter helper was passing `--pid host` to `podman create`, which
crun rejects on some host configurations with:
Error: containers not creating Cgroups must create a private PID
namespace: invalid argument
ERROR: Failed to create WebKit Container SDK container named
'wkdev-build'.
Remove --pid host, we don't need it for the wkdev-build container
(unlike the full SDK container, for convenience).
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_build_podman_create_args):
Canonical link: https://commits.webkit.org/313232@main
Canonical link: https://commits.webkit.org/305877.639@webkitglib/2.52
Commit: ae32c316b13d9cd36a357c7fd6404ed111a9a1a1
https://github.com/WebKit/WebKit/commit/ae32c316b13d9cd36a357c7fd6404ed111a9a1a1
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
Cherry-pick 313235@main (3ece54788730).
https://bugs.webkit.org/show_bug.cgi?id=314810
[GTK][WPE] Cap wkdev-build container hostname to HOST_NAME_MAX
https://bugs.webkit.org/show_bug.cgi?id=314810
Unreviewed build fix.
In a Kubernetes pod the host hostname is the pod name (up to 63 chars),
so blindly appending it to the container name overflows the 64-byte
HOST_NAME_MAX. crun then fails to start the container with:
Error: OCI runtime error: ... crun: sethostname: Invalid argument
ERROR: Failed to start container 'wkdev-build'.
Route the hostname through a small helper that truncates to 63 chars.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_container_hostname):
(_build_podman_create_args):
Canonical link: https://commits.webkit.org/313235@main
Canonical link: https://commits.webkit.org/305877.640@webkitglib/2.52
Commit: a0510d98a7117d411fe7f9d5233b04eea6c8cfb4
https://github.com/WebKit/WebKit/commit/a0510d98a7117d411fe7f9d5233b04eea6c8cfb4
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
Cherry-pick 313242@main (e9ddfb6d1b2b).
https://bugs.webkit.org/show_bug.cgi?id=314819
[GTK][WPE][Tools] layout tests are failing when using the auto-enter WebKit
Container SDK environment
https://bugs.webkit.org/show_bug.cgi?id=314819
Reviewed by Nikolas Zimmermann.
The http server used on the layout test is unable to start with the new
auto-enter
WebKit Container SDK environment because the tooling is failing to resolve
the username.
This is because the tooling is trying to resolve the username from the
environment,
and the USER or USERNAME env variables are not forwarded into it.
Fix this by ensuring this variables are forwarded, can be useful for other
things,
and also fix apache_http_server.py to call getuser() when those are not set.
* Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.__init__):
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
Canonical link: https://commits.webkit.org/313242@main
Canonical link: https://commits.webkit.org/305877.641@webkitglib/2.52
Commit: bcae4ff1c099bc59859dfa4dd0e18a15dd92856d
https://github.com/WebKit/WebKit/commit/bcae4ff1c099bc59859dfa4dd0e18a15dd92856d
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
M Tools/glib/dependencies/apt
M Tools/glib/dependencies/dnf
M Tools/glib/dependencies/pacman
Log Message:
-----------
Cherry-pick 313275@main (7c6ce8fd9c0a).
https://bugs.webkit.org/show_bug.cgi?id=314841
[GTK][WPE][Tools] Make wkdev-build container ephemeral
https://bugs.webkit.org/show_bug.cgi?id=314841
Reviewed by Carlos Alberto Lopez Perez.
The persistent container required manual `podman rm` whenever its
create arguments changed, paid the first-run recursive chown cost,
and needed a `podman start` step after host reboots.
Switch to `podman run --rm --init` per host wrapper invocation. Run
as $UID:$GID with `--userns keep-id`; /run/user/<uid> comes from a
`--mount type=tmpfs,chown=true` whose ownership is set at mount time,
which removes the privileged init phase and the recursive chown. An
inline entrypoint refreshes the Wayland / PipeWire socket symlinks
and flatpak helper dirs in $XDG_RUNTIME_DIR, then execs the user
command.
Add podman/catatonit/crun as required packages to the dependencies
files.
Also fix coredumps:
Mount /var/lib/systemd/coredump and /var/log/journal (read-only) into the
wkdev-build container so that coredumpctl works inside it. Crashes inside
the container are handled by the host's core_pattern / systemd-coredump,
which writes to /var/lib/systemd/coredump; without these mounts the files
and their journal metadata are invisible to coredumpctl running in the
container.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_translate_host_path_to_container):
(_build_podman_run_args):
(maybe_enter_webkit_container_sdk):
(_podman_container_info): Deleted.
(_build_podman_create_args): Deleted.
(_init_and_sync_container_runtime): Deleted.
(_stop_and_remove_container): Deleted.
(_create_container): Deleted.
(_ensure_container_ready): Deleted.
* Tools/glib/dependencies/apt:
* Tools/glib/dependencies/dnf:
* Tools/glib/dependencies/pacman:
Canonical link: https://commits.webkit.org/313275@main
Canonical link: https://commits.webkit.org/305877.642@webkitglib/2.52
Commit: e25fb1dd4364b58fe5c2d61f80aa75da3a24ee56
https://github.com/WebKit/WebKit/commit/e25fb1dd4364b58fe5c2d61f80aa75da3a24ee56
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
Cherry-pick 313330@main (c57f26e01334).
https://bugs.webkit.org/show_bug.cgi?id=314907
[GTK][WPE][Tools] container-sdk-autoenter fails on bots with /dev/console
mount error
https://bugs.webkit.org/show_bug.cgi?id=314907
Reviewed by Carlos Alberto Lopez Perez.
In nested rootless setups (LXC, k8s pods, Docker/podman) crun aborts
container startup with `mount /dev/pts/N to /dev/console: No such file
or directory`. Root cause: binding the host's entire /dev over the
container's (`-v /dev:/dev:rslave`) shadows the container's /dev, so
under --tty crun cannot create /dev/console from the allocated pty -- a
nested pod's /dev has none for it to bind onto.
Generalize the prior LXC-only check to a `_running_inside_container()`
helper and use it to skip only the wholesale host /dev bind in that
case, letting crun own /dev. --tty and the container's own devpts are
kept, so interactive shells still get a controlling terminal on bots.
GPU (/dev/dri) and e.g. gamepads (/dev/input) are passed through explicitly.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_running_inside_container):
(_build_podman_run_args):
(maybe_enter_webkit_container_sdk):
Canonical link: https://commits.webkit.org/313330@main
Canonical link: https://commits.webkit.org/305877.643@webkitglib/2.52
Commit: 1a498763aa7b6d6da8ca0c382e7bd518c2160d00
https://github.com/WebKit/WebKit/commit/1a498763aa7b6d6da8ca0c382e7bd518c2160d00
Author: Claudio Saavedra <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/run-wpe-tests
M Tools/glib/api_test_runner.py
Log Message:
-----------
Cherry-pick 313388@main (740bb59299a6).
https://bugs.webkit.org/show_bug.cgi?id=314983
[WPE] API test results uploaded from --wpe-legacy-api runner are not tagged
with the wpe-legacy-api flavor
https://bugs.webkit.org/show_bug.cgi?id=314983
Reviewed by Fujii Hironori.
The "WPE-Linux-64-bit-Release-Legacy-API-Tests" runner passes
--wpe-legacy-api to run-wpe-tests. The flag is forwarded to the test
binaries so they exercise the legacy WPE API, but unlike the
layout-test path in run_webkit_tests.py, it is never translated into
options.result_report_flavor. As a consequence,
Port.configuration_for_upload() emits an upload with no flavor field
and results.webkit.org has no rows for the wpe-legacy-api flavor of
the api-tests suite.
Mirror the layout-test pattern in run-wpe-tests so --wpe-legacy-api
implicitly sets result_report_flavor='wpe-legacy-api'. Additionally,
forward result_report_flavor through api_test_runner's port_options()
helper, which previously stripped everything except the build
configuration when constructing the port.
* Tools/Scripts/run-wpe-tests:
* Tools/glib/api_test_runner.py:
(port_options):
Canonical link: https://commits.webkit.org/313388@main
Canonical link: https://commits.webkit.org/305877.644@webkitglib/2.52
Commit: 1af653e97e6b564095a4b78414f8f75247f4a6e4
https://github.com/WebKit/WebKit/commit/1af653e97e6b564095a4b78414f8f75247f4a6e4
Author: Claudio Saavedra <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp
Log Message:
-----------
Cherry-pick 313399@main (022b2f9f8c6c).
https://bugs.webkit.org/show_bug.cgi?id=315000
[GTK][WPE] Skip ResponsivenessTimer API tests in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=315000
Reviewed by Adrian Perez de Castro.
TestWebKitWebView's /webkit/WebKitWebView/is-web-process-responsive and
/webkit/WebKitWebView/terminate-unresponsive-web-process tests time out
on Debug bots because ResponsivenessTimer::mayBecomeUnresponsive() is
hard-coded to return false when NDEBUG is not defined, so the web
process is never reported as unresponsive and the tests hang waiting
for the notify::is-web-process-responsive property change.
Mirror the existing Cocoa pattern in
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm, which
already guards the equivalent positive-responsiveness tests with NDEBUG.
* Tools/TestWebKitAPI/Tests/WebKit/WKPage/glib/TestWebKitWebView.cpp:
(beforeAll):
Canonical link: https://commits.webkit.org/313399@main
Canonical link: https://commits.webkit.org/305877.645@webkitglib/2.52
Commit: 3a95c9a2cce549d8bba8cb2b61fcc40bb9448837
https://github.com/WebKit/WebKit/commit/3a95c9a2cce549d8bba8cb2b61fcc40bb9448837
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/generate-bundle
Log Message:
-----------
Cherry-pick 313406@main (1e4e943ea4d8).
https://bugs.webkit.org/show_bug.cgi?id=315009
[Tools] generate-bundle must re-exec under the /sdk/webkit mount namespace
https://bugs.webkit.org/show_bug.cgi?id=315009
Reviewed by Claudio Saavedra.
generate-bundle entered the WebKit Container SDK but, unlike build-webkit
and the run-* scripts, never called maybe_use_container_sdk_root_dir().
With the tree mounted at a different path than at build time, the RPATH
baked into the WebKit binaries (/sdk/webkit/WebKitBuild/.../lib) failed
to resolve, causing ldd "libWPEWebKit-2.0.so.1 => not found".
* Tools/Scripts/generate-bundle:
Canonical link: https://commits.webkit.org/313406@main
Canonical link: https://commits.webkit.org/305877.646@webkitglib/2.52
Commit: 07a02f8726a61d29082db05c4c801417ad618798
https://github.com/WebKit/WebKit/commit/07a02f8726a61d29082db05c4c801417ad618798
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
Log Message:
-----------
Cherry-pick 313529@main (ab85063d24ab).
https://bugs.webkit.org/show_bug.cgi?id=315125
[Tools] Share host PID namespace with ephemeral container by default
https://bugs.webkit.org/show_bug.cgi?id=315125
Reviewed by Carlos Alberto Lopez Perez.
Add --pid host to the podman run args so coredumpctl can resolve the host
PIDs recorded by systemd-coredump (and the bind-mounted journal) from inside
the container. The same shared namespace also lets gdb/lldb attach and perf
target host processes by their PIDs from the host.
Gated on WEBKIT_CONTAINER_SDK_SHARE_HOST_PID_NAMESPACE; default on, set to 0
to fall back to a private PID namespace (desired bot configuration!).
For this to work we have to drrop --init when sharing the host PID
namespace:
podman refuses to inject a new PID 1 there (the host's already exists), and
orphaned processes are reparented to host PID 1 which reaps them.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_build_podman_run_args):
Canonical link: https://commits.webkit.org/313529@main
Canonical link: https://commits.webkit.org/305877.647@webkitglib/2.52
Commit: 59c82b7b4be42e67b9b3ea4202c1e853ee2a34f1
https://github.com/WebKit/WebKit/commit/59c82b7b4be42e67b9b3ea4202c1e853ee2a34f1
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/run-mvt-tests
Log Message:
-----------
Cherry-pick 313558@main (033b941bf0b2).
https://bugs.webkit.org/show_bug.cgi?id=315169
[Tools] Make run-mvt-tests honor the WebKit Container SDK auto-enter
https://bugs.webkit.org/show_bug.cgi?id=315169
Reviewed by Claudio Saavedra.
Mirror the pattern already used by run-webkit-tests / run-wpe-tests so
that run-mvt-tests re-execs into the wkdev-build container (when
WEBKIT_CONTAINER_SDK_ENABLE_AUTOENTER=1) and switches to the
/sdk/webkit bind mount via a private mount namespace once inside.
maybe_enter_webkit_container_sdk() runs before the selenium / urllib3
imports so those heavy dependencies are resolved inside the container
rather than on the host, where they may not be installed.
* Tools/Scripts/run-mvt-tests:
Canonical link: https://commits.webkit.org/313558@main
Canonical link: https://commits.webkit.org/305877.648@webkitglib/2.52
Commit: eef7433a48bd509808ee308896616668f83bb87e
https://github.com/WebKit/WebKit/commit/eef7433a48bd509808ee308896616668f83bb87e
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
A Tools/Scripts/webkitpy/port/linux_container_sdk_utils_unittest.py
Log Message:
-----------
Cherry-pick 313569@main (703a0299474b).
https://bugs.webkit.org/show_bug.cgi?id=315178
[GTK][WPE][Tools] container-sdk-autoenter doesn't forward
DBUS_SESSION_BUS_ADDRESS when that includes a ,guid string
https://bugs.webkit.org/show_bug.cgi?id=315178
Reviewed by Nikolas Zimmermann.
On the bots the value of DBUS_SESSION_BUS_ADDRESS includes a ",guid" suffix
because
it is obtained via dbus-launch.
The current function to obtain the path from the value was not handling
that case.
Fix it and also add some unit tests.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_strip_unix_path_prefix):
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils_unittest.py: Added.
(ContainerSDKHelpersTest):
(ContainerSDKHelpersTest.test_dbus_standard_path):
(ContainerSDKHelpersTest.test_dbus_autolaunch_path):
(ContainerSDKHelpersTest.test_pulse_server_path):
(ContainerSDKHelpersTest.test_at_spi_bus_path):
Canonical link: https://commits.webkit.org/313569@main
Canonical link: https://commits.webkit.org/305877.649@webkitglib/2.52
Commit: 6b9c89b1e354ea738032899d5366a15dd3469d96
https://github.com/WebKit/WebKit/commit/6b9c89b1e354ea738032899d5366a15dd3469d96
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py
M Tools/Scripts/webkitpy/port/linux_container_sdk_utils_unittest.py
Log Message:
-----------
Cherry-pick 313570@main (d0c317ee7c58).
https://bugs.webkit.org/show_bug.cgi?id=315187
[GTK][WPE][Tools] Improve bind mount of AT-SPI socket for
container-sdk-autoenter
https://bugs.webkit.org/show_bug.cgi?id=315187
Reviewed by Nikolas Zimmermann.
The current code on container-sdk-autoenter only checks the socket at env
var
AT_SPI_BUS_ADDRESS (usually undefined) or at the usual place, but it could
also ask dbus for where this socket is.
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils.py:
(_strip_unix_path_prefix):
(_get_at_spi_bus_socket_or_dir_and_var):
(_get_at_spi_bus_socket_or_dir_and_var._socket_or_none):
(_build_podman_run_args):
* Tools/Scripts/webkitpy/port/linux_container_sdk_utils_unittest.py:
(StripUnixPathPrefixTest):
(StripUnixPathPrefixTest.test_at_spi_bus_path):
(GetAtSpiBusDirTest):
(GetAtSpiBusDirTest.setUp):
(GetAtSpiBusDirTest._close_sockets):
(GetAtSpiBusDirTest._make_socket):
(GetAtSpiBusDirTest._mock_gdbus):
(GetAtSpiBusDirTest.test_env_var_points_to_socket):
(GetAtSpiBusDirTest.test_env_var_missing_socket_falls_through):
(GetAtSpiBusDirTest.test_env_var_regular_file_falls_through):
(GetAtSpiBusDirTest.test_gdbus_returns_socket):
(GetAtSpiBusDirTest.test_gdbus_missing_socket_falls_through):
(GetAtSpiBusDirTest.test_gdbus_not_installed_falls_through):
(GetAtSpiBusDirTest.test_gdbus_timeout_falls_through):
(GetAtSpiBusDirTest.test_gdbus_malformed_output_falls_through):
(GetAtSpiBusDirTest.test_falls_back_to_xdg_dir):
(GetAtSpiBusDirTest.test_returns_none_when_nothing_resolves):
(ContainerSDKHelpersTest): Deleted.
(ContainerSDKHelpersTest.test_dbus_standard_path): Deleted.
(ContainerSDKHelpersTest.test_dbus_autolaunch_path): Deleted.
(ContainerSDKHelpersTest.test_pulse_server_path): Deleted.
(ContainerSDKHelpersTest.test_at_spi_bus_path): Deleted.
Canonical link: https://commits.webkit.org/313570@main
Canonical link: https://commits.webkit.org/305877.650@webkitglib/2.52
Commit: 63e41944a88dad740e5decbc4b261a8fb5fa5495
https://github.com/WebKit/WebKit/commit/63e41944a88dad740e5decbc4b261a8fb5fa5495
Author: Philippe Normand <[email protected]>
Date: 2026-05-21 (Thu, 21 May 2026)
Changed paths:
M Tools/Scripts/run-mvt-tests
Log Message:
-----------
Cherry-pick 313657@main (4a7ed8d2f72f).
https://bugs.webkit.org/show_bug.cgi?id=315150
REGRESSION(313145@main): 3 unexpected failures on MVT tests on suite
hls-shaka-test
https://bugs.webkit.org/show_bug.cgi?id=315150
Reviewed by Xabier Rodriguez-Calvar.
Restore the timestamp update logic from before 313145@main, some values
will be reported as negative
but actual timestamps stored in buffers are guaranteed to be positive.
Driving-by, fix a python syntax warning in run-mvt-tests, apparently
'return' is not allowed in
finally blocks anymore.
* Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::updateSampleTimestamps):
(WebCore::MediaSampleGStreamer::offsetTimestampsBy):
* Tools/Scripts/run-mvt-tests:
Canonical link: https://commits.webkit.org/313657@main
Canonical link: https://commits.webkit.org/305877.651@webkitglib/2.52
Compare: https://github.com/WebKit/WebKit/compare/7adb7d379d57...63e41944a88d
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
