Title: [114936] trunk/Source/WebCore
- Revision
- 114936
- Author
- e...@chromium.org
- Date
- 2012-04-23 13:17:31 -0700 (Mon, 23 Apr 2012)
Log Message
Crash in RenderInline::clippedOverflowRectForRepaint for PrintPreview
https://bugs.webkit.org/show_bug.cgi?id=84300
Reviewed by Simon Fraser.
No new tests, have not been able to come up with a reliable reduction.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Add NULL check for containingBlock() as it can return NULL when detached
from the tree.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114935 => 114936)
--- trunk/Source/WebCore/ChangeLog 2012-04-23 20:12:20 UTC (rev 114935)
+++ trunk/Source/WebCore/ChangeLog 2012-04-23 20:17:31 UTC (rev 114936)
@@ -1,3 +1,17 @@
+2012-04-23 Emil A Eklund <e...@chromium.org>
+
+ Crash in RenderInline::clippedOverflowRectForRepaint for PrintPreview
+ https://bugs.webkit.org/show_bug.cgi?id=84300
+
+ Reviewed by Simon Fraser.
+
+ No new tests, have not been able to come up with a reliable reduction.
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clippedOverflowRectForRepaint):
+ Add NULL check for containingBlock() as it can return NULL when detached
+ from the tree.
+
2012-04-23 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r114929.
Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (114935 => 114936)
--- trunk/Source/WebCore/rendering/RenderInline.cpp 2012-04-23 20:12:20 UTC (rev 114935)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2012-04-23 20:17:31 UTC (rev 114936)
@@ -1031,7 +1031,7 @@
LayoutRect r(-ow + left, -ow + top, boundingBox.width() + ow * 2, boundingBox.height() + ow * 2);
- if (hitRepaintContainer)
+ if (hitRepaintContainer || !cb)
return r;
if (cb->hasColumns())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
