Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0fc1e487ba5260679e65e8066c2c5b2aa4bb738e
https://github.com/WebKit/WebKit/commit/0fc1e487ba5260679e65e8066c2c5b2aa4bb738e
Author: Zak Ridouh <[email protected]>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M Source/WebKit/Headers.cmake
M Source/WebKit/Modules/OSX_Private.modulemap
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/Shared/API/APIObject.h
M Source/WebKit/Shared/API/c/WKBase.h
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
R Source/WebKit/UIProcess/API/APIIconDatabaseClient.h
M Source/WebKit/UIProcess/API/C/WKAPICast.h
M Source/WebKit/UIProcess/API/C/WKContext.cpp
M Source/WebKit/UIProcess/API/C/WKContext.h
M Source/WebKit/UIProcess/API/C/WKContextPrivate.h
R Source/WebKit/UIProcess/API/C/WKIconDatabase.cpp
R Source/WebKit/UIProcess/API/C/WKIconDatabase.h
R Source/WebKit/UIProcess/API/C/cg/WKIconDatabaseCG.cpp
R Source/WebKit/UIProcess/API/C/cg/WKIconDatabaseCG.h
M Source/WebKit/UIProcess/Inspector/WasmDebuggerDebuggable.cpp
R Source/WebKit/UIProcess/WebIconDatabase.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/WebKitTestRunner/TestController.cpp
Log Message:
-----------
Remove dead WKIconDatabase C API, WebIconDatabase, and APIIconDatabaseClient
<https://bugs.webkit.org/show_bug.cgi?id=314500>
<rdar://problem/176714451>
Reviewed by Alex Christensen and Adrian Perez de Castro.
Every WKIconDatabase (and WKIconDatabaseCG) function is a no-op or
returns nullptr. The backing WebIconDatabase class has an empty body
and is never constructed. APIIconDatabaseClient has no subclasses.
WKContextGetIconDatabase and WKContextSetIconDatabasePath are no-ops;
WebKitTestRunner was their only caller. Delete it all.
The WebKitLegacy WebIconDatabase in Source/WebKitLegacy/mac/Misc/ and
the GTK/WPE WebKitFaviconDatabase glib API are unrelated and untouched.
* Source/WebKit/Headers.cmake:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Shared/API/APIObject.h:
* Source/WebKit/Shared/API/c/WKBase.h:
* Source/WebKit/Sources.txt:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/APIIconDatabaseClient.h: Removed.
* Source/WebKit/UIProcess/API/C/WKAPICast.h:
* Source/WebKit/UIProcess/API/C/WKContext.cpp:
(WKContextGetIconDatabase): Deleted.
(WKContextSetIconDatabasePath): Deleted.
* Source/WebKit/UIProcess/API/C/WKContext.h:
* Source/WebKit/UIProcess/API/C/WKContextPrivate.h:
* Source/WebKit/UIProcess/API/C/WKIconDatabase.cpp: Removed.
* Source/WebKit/UIProcess/API/C/WKIconDatabase.h: Removed.
* Source/WebKit/UIProcess/API/C/cg/WKIconDatabaseCG.cpp: Removed.
* Source/WebKit/UIProcess/API/C/cg/WKIconDatabaseCG.h: Removed.
* Source/WebKit/UIProcess/Inspector/WasmDebuggerDebuggable.cpp:
* Source/WebKit/UIProcess/WebIconDatabase.h: Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::~TestController):
(WTR::TestController::generatePageConfiguration):
Canonical link: https://commits.webkit.org/313751@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
