[webkit-changes] [WebKit/WebKit] 3ce3ac: Use OrderedHashSet for addSubresourceAttributeURLs...

Sat, 23 May 2026 11:07:58 -0700 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ce3ac9b63c0d206fd313f6e32b0540d82dea12a
      
https://github.com/WebKit/WebKit/commit/3ce3ac9b63c0d206fd313f6e32b0540d82dea12a
  Author: Tim Nguyen <[email protected]>
  Date:   2026-05-23 (Sat, 23 May 2026)

  Changed paths:
    M Source/WebCore/dom/CustomStateSet.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/Node.h
    M Source/WebCore/dom/NodeInlines.h
    M Source/WebCore/dom/ProcessingInstruction.cpp
    M Source/WebCore/dom/ProcessingInstruction.h
    M Source/WebCore/dom/StyledElement.cpp
    M Source/WebCore/dom/StyledElement.h
    M Source/WebCore/html/HTMLBodyElement.cpp
    M Source/WebCore/html/HTMLBodyElement.h
    M Source/WebCore/html/HTMLEmbedElement.cpp
    M Source/WebCore/html/HTMLEmbedElement.h
    M Source/WebCore/html/HTMLImageElement.cpp
    M Source/WebCore/html/HTMLImageElement.h
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.h
    M Source/WebCore/html/HTMLLinkElement.cpp
    M Source/WebCore/html/HTMLLinkElement.h
    M Source/WebCore/html/HTMLObjectElement.cpp
    M Source/WebCore/html/HTMLObjectElement.h
    M Source/WebCore/html/HTMLScriptElement.cpp
    M Source/WebCore/html/HTMLScriptElement.h
    M Source/WebCore/html/HTMLSourceElement.cpp
    M Source/WebCore/html/HTMLSourceElement.h
    M Source/WebCore/html/HTMLStyleElement.cpp
    M Source/WebCore/html/HTMLStyleElement.h
    M Source/WebCore/html/HTMLTableCellElement.cpp
    M Source/WebCore/html/HTMLTableCellElement.h
    M Source/WebCore/html/HTMLTableElement.cpp
    M Source/WebCore/html/HTMLTableElement.h
    M Source/WebCore/html/parser/HTMLSrcsetParser.cpp
    M Source/WebCore/html/parser/HTMLSrcsetParser.h
    M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
    M Source/WebCore/svg/SVGFEImageElement.cpp
    M Source/WebCore/svg/SVGFEImageElement.h
    M Source/WebCore/svg/SVGImageElement.cpp
    M Source/WebCore/svg/SVGImageElement.h
    M Source/WebCore/svg/SVGScriptElement.cpp
    M Source/WebCore/svg/SVGScriptElement.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h

  Log Message:
  -----------
  Use OrderedHashSet for addSubresourceAttributeURLs & 
addCandidateSubresourceURLs
https://bugs.webkit.org/show_bug.cgi?id=315396
rdar://177749944

Reviewed by Darin Adler.

OrderedHashSet is faster & equivalent to ListHashSet. Use it instead. There is 
no call site that edits the set while iterating over it, so the conversion is 
safe.

* Source/WebCore/dom/CustomStateSet.h:
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::getSubresourceURLs const):
(WebCore::Node::getCandidateSubresourceURLs const):
* Source/WebCore/dom/Node.h:
(WebCore::Node::addSubresourceAttributeURLs const):
(WebCore::Node::addCandidateSubresourceURLs const):
* Source/WebCore/dom/NodeInlines.h:
(WebCore::addSubresourceURL):
* Source/WebCore/dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::addSubresourceAttributeURLs const):
* Source/WebCore/dom/ProcessingInstruction.h:
* Source/WebCore/dom/StyledElement.cpp:
(WebCore::StyledElement::addSubresourceAttributeURLs const):
* Source/WebCore/dom/StyledElement.h:
* Source/WebCore/html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLBodyElement.h:
* Source/WebCore/html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLEmbedElement.h:
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::addSubresourceAttributeURLs const):
(WebCore::HTMLImageElement::addCandidateSubresourceURLs const):
* Source/WebCore/html/HTMLImageElement.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLLinkElement.h:
* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLObjectElement.h:
* Source/WebCore/html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLScriptElement.h:
* Source/WebCore/html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::addCandidateSubresourceURLs const):
* Source/WebCore/html/HTMLSourceElement.h:
* Source/WebCore/html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLStyleElement.h:
* Source/WebCore/html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLTableCellElement.h:
* Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLTableElement.h:
* Source/WebCore/html/parser/HTMLSrcsetParser.cpp:
(WebCore::getURLsFromSrcsetAttribute):
* Source/WebCore/html/parser/HTMLSrcsetParser.h:
* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createInternal):
* Source/WebCore/svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::addSubresourceAttributeURLs const):
* Source/WebCore/svg/SVGFEImageElement.h:
* Source/WebCore/svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::addSubresourceAttributeURLs const):
* Source/WebCore/svg/SVGImageElement.h:
* Source/WebCore/svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::addSubresourceAttributeURLs const):
* Source/WebCore/svg/SVGScriptElement.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:

Canonical link: https://commits.webkit.org/313791@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to