Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 19e0726161fc1b0a44ac88937026cdbdf68c8aa2
https://github.com/WebKit/WebKit/commit/19e0726161fc1b0a44ac88937026cdbdf68c8aa2
Author: Charlie Wolfe <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
M Configurations/CommonBase.xcconfig
Log Message:
-----------
Fix inverted SPI auditing gate for `OVERRIDE_SUPPORTS_TEXT_BASED_API`
https://bugs.webkit.org/show_bug.cgi?id=315784
rdar://178180906
Reviewed by Elliott Williams.
304191@main intended to skip the iOS SPI audit when TAPI is locally disabled
(OVERRIDE_SUPPORTS_TEXT_BASED_API=NO), but the formula did the opposite: it
only skipped the audit
when OVERRIDE_SUPPORTS_TEXT_BASED_API=YES.
Old: WK_NOT_(WK_OR_(SANITIZER, OVERRIDE)) -- skips audit iff OVERRIDE=YES
New: WK_AND_(WK_NOT_(SANITIZER), OVERRIDE:default=YES)
-- audits iff !sanitizer &&
TAPI on
The :default=YES form ensures the unset case still audits, while an explicit NO
(the value that
actually turns TAPI off) now skips the audit as intended. Sanitizer behavior is
unchanged.
* Configurations/CommonBase.xcconfig:
Canonical link: https://commits.webkit.org/314083@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
