Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f8724ce449ab8f5534b9cb0669729b45054d2ec1
https://github.com/WebKit/WebKit/commit/f8724ce449ab8f5534b9cb0669729b45054d2ec1
Author: Sam Weinig <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoDeleteCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSAppleColorFilterValue.cpp
M Source/WebCore/css/CSSAppleColorFilterValue.h
M Source/WebCore/css/CSSBorderImageSourceValue.cpp
M Source/WebCore/css/CSSBorderImageSourceValue.h
M Source/WebCore/css/CSSBoxShadowPropertyValue.cpp
M Source/WebCore/css/CSSBoxShadowPropertyValue.h
M Source/WebCore/css/CSSClipValue.cpp
M Source/WebCore/css/CSSClipValue.h
M Source/WebCore/css/CSSColorValue.cpp
M Source/WebCore/css/CSSColorValue.h
M Source/WebCore/css/CSSContentValue.cpp
M Source/WebCore/css/CSSContentValue.h
R Source/WebCore/css/CSSCounterValue.cpp
R Source/WebCore/css/CSSCounterValue.h
M Source/WebCore/css/CSSCustomIdentValue.cpp
M Source/WebCore/css/CSSCustomIdentValue.h
M Source/WebCore/css/CSSFilterValue.cpp
M Source/WebCore/css/CSSFilterValue.h
M Source/WebCore/css/CSSFontFamilyNameValue.cpp
M Source/WebCore/css/CSSFontFamilyNameValue.h
M Source/WebCore/css/CSSImageSetValue.cpp
M Source/WebCore/css/CSSImageSetValue.h
M Source/WebCore/css/CSSImageValue.cpp
M Source/WebCore/css/CSSImageValue.h
M Source/WebCore/css/CSSKeywordValue.cpp
M Source/WebCore/css/CSSKeywordValue.h
M Source/WebCore/css/CSSMaskBorderSourceValue.cpp
M Source/WebCore/css/CSSMaskBorderSourceValue.h
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSPropertyInitialValues.cpp
R Source/WebCore/css/CSSQuadValue.cpp
R Source/WebCore/css/CSSQuadValue.h
M Source/WebCore/css/CSSQuotesValue.cpp
M Source/WebCore/css/CSSQuotesValue.h
R Source/WebCore/css/CSSRectValue.cpp
R Source/WebCore/css/CSSRectValue.h
M Source/WebCore/css/CSSStringValue.cpp
M Source/WebCore/css/CSSStringValue.h
M Source/WebCore/css/CSSTextShadowPropertyValue.cpp
M Source/WebCore/css/CSSTextShadowPropertyValue.h
M Source/WebCore/css/CSSTransformListValue.cpp
M Source/WebCore/css/CSSTransformListValue.h
M Source/WebCore/css/CSSURLValue.cpp
M Source/WebCore/css/CSSURLValue.h
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueList.cpp
M Source/WebCore/css/CSSValueList.h
M Source/WebCore/css/CSSValuePair.cpp
M Source/WebCore/css/CSSValuePair.h
R Source/WebCore/css/Quad.h
R Source/WebCore/css/Rect.h
R Source/WebCore/css/RectBase.h
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.h
R
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.cpp
R
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.h
A Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValueData.cpp
A Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValueData.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRGBColor.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.cpp
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.h
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValue.h
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
M Source/WebCore/css/parser/CSSPropertyParserCustom.h
M Source/WebCore/css/typedom/StylePropertyMap.cpp
A Source/WebCore/css/values/CSSValueTypes+DeprecatedCSSOMValueCreation.cpp
A Source/WebCore/css/values/CSSValueTypes+DeprecatedCSSOMValueCreation.h
M Source/WebCore/css/values/CSSValueTypes.cpp
M Source/WebCore/css/values/CSSValueTypes.h
R Source/WebCore/css/values/borders/CSSBoxShadow.cpp
M Source/WebCore/css/values/borders/CSSBoxShadow.h
M Source/WebCore/css/values/color/CSSColor.cpp
M Source/WebCore/css/values/content/CSSContent.cpp
M Source/WebCore/css/values/content/CSSContent.h
R Source/WebCore/css/values/filter-effects/CSSAppleColorFilter.cpp
M Source/WebCore/css/values/filter-effects/CSSAppleColorFilter.h
R Source/WebCore/css/values/filter-effects/CSSFilter.cpp
M Source/WebCore/css/values/filter-effects/CSSFilter.h
M Source/WebCore/css/values/fonts/CSSFontFamilyName.cpp
M Source/WebCore/css/values/fonts/CSSFontFamilyName.h
M Source/WebCore/css/values/masking/CSSClip.cpp
M Source/WebCore/css/values/primitives/CSSCustomIdent.cpp
M Source/WebCore/css/values/primitives/CSSKeyword.cpp
M Source/WebCore/css/values/primitives/CSSKeyword.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRaw.h
M
Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+DeprecatedCSSOMValueCreation.h
M Source/WebCore/css/values/primitives/CSSString.cpp
M Source/WebCore/css/values/primitives/CSSString.h
M Source/WebCore/css/values/primitives/CSSURL.cpp
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
R Source/WebCore/css/values/text-decoration/CSSTextShadow.cpp
M Source/WebCore/css/values/text-decoration/CSSTextShadow.h
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleCustomProperty.cpp
A Source/WebCore/style/values/StyleValueTypes+DeprecatedCSSOMValueCreation.h
M Source/WebCore/style/values/StyleValueTypes.h
M Source/WebCore/style/values/backgrounds/StyleBorderImageOutset.cpp
Log Message:
-----------
Refactor DeprecatedCSSOMValue types to not wrap CSSValue (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=315682
Reviewed by Darin Adler.
Finishes moving DeprecatedCSSOMValue off of CSSValue.
- DeprecatedCSSOMPrimitiveValue now wraps Variant of strong CSS types
along with one catch-all lazy serialization functor for a few cases
where only the serialization is needed, like CSSValuePair.
- Moves the remaining uses of DeprecatedCSSOMCustomValue to use the
lazy serialization functor approach, allowing merging of
DeprecatedCSSOMCustomValue
and DeprecatedCSSOMLazySerializingCustomValue into a single
DeprecatedCSSOMCustomValue
type once again.
- Makes CSSValue::createDeprecatedCSSOMWrapper() use the the visitDerived
pattern, adding a new customCreateDeprecatedCSSOMWrapper() overload
opportunity and moving the special cases in CSSValue to their respective
subclasses. The default, in CSSValue itself, uses DeprecatedCSSOMCustomValue.
- Moved all but the initial declaration of the DeprecatedCSSOMValueCreation
protocol types out of CSSValueTypes.h/StyleValueTypes.h and into their own
files. Going forward, this will be the pattern to follow and the other
protocols
will eventually also be split out, allowing more fine grain includes.
- Removes a few now unused types (Rect, CSSRectValue, Quad, CSSQuadValue).
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSAppleColorFilterValue.cpp:
* Source/WebCore/css/CSSAppleColorFilterValue.h:
* Source/WebCore/css/CSSBorderImageSourceValue.cpp:
* Source/WebCore/css/CSSBorderImageSourceValue.h:
* Source/WebCore/css/CSSBoxShadowPropertyValue.cpp:
* Source/WebCore/css/CSSBoxShadowPropertyValue.h:
* Source/WebCore/css/CSSClipValue.cpp:
* Source/WebCore/css/CSSClipValue.h:
* Source/WebCore/css/CSSColorValue.cpp:
* Source/WebCore/css/CSSColorValue.h:
* Source/WebCore/css/CSSContentValue.cpp:
* Source/WebCore/css/CSSContentValue.h:
* Source/WebCore/css/CSSCounterValue.cpp: Removed.
* Source/WebCore/css/CSSCustomIdentValue.cpp:
* Source/WebCore/css/CSSCustomIdentValue.h:
* Source/WebCore/css/CSSFilterValue.cpp:
* Source/WebCore/css/CSSFilterValue.h:
* Source/WebCore/css/CSSFontFamilyNameValue.cpp:
* Source/WebCore/css/CSSFontFamilyNameValue.h:
* Source/WebCore/css/CSSImageSetValue.cpp:
* Source/WebCore/css/CSSImageSetValue.h:
* Source/WebCore/css/CSSImageValue.cpp:
* Source/WebCore/css/CSSImageValue.h:
* Source/WebCore/css/CSSKeywordValue.cpp:
* Source/WebCore/css/CSSKeywordValue.h:
* Source/WebCore/css/CSSMaskBorderSourceValue.cpp:
* Source/WebCore/css/CSSMaskBorderSourceValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSPropertyInitialValues.cpp:
* Source/WebCore/css/CSSQuadValue.cpp: Removed.
* Source/WebCore/css/CSSQuadValue.h: Removed.
* Source/WebCore/css/CSSQuotesValue.cpp:
* Source/WebCore/css/CSSQuotesValue.h:
* Source/WebCore/css/CSSRectValue.h: Removed.
* Source/WebCore/css/CSSStringValue.cpp:
* Source/WebCore/css/CSSStringValue.h:
* Source/WebCore/css/CSSTextShadowPropertyValue.cpp:
* Source/WebCore/css/CSSTextShadowPropertyValue.h:
* Source/WebCore/css/CSSTransformListValue.cpp:
* Source/WebCore/css/CSSTransformListValue.h:
* Source/WebCore/css/CSSURLValue.cpp:
* Source/WebCore/css/CSSURLValue.h:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/CSSValueList.cpp:
* Source/WebCore/css/CSSValueList.h:
* Source/WebCore/css/CSSValuePair.cpp:
* Source/WebCore/css/CSSValuePair.h:
* Source/WebCore/css/Quad.h: Removed.
* Source/WebCore/css/Rect.h: Removed.
* Source/WebCore/css/RectBase.h: Removed.
* Source/WebCore/css/ShorthandSerializer.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMCustomValue.h:
*
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.cpp:
Removed.
*
Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMLazySerializingCustomValue.h:
Removed.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValueData.cpp:
Added.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValueData.h:
Added.
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRGBColor.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.cpp:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMRect.h:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMValue.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp:
* Source/WebCore/css/parser/CSSPropertyParserCustom.h:
* Source/WebCore/css/typedom/StylePropertyMap.cpp:
* Source/WebCore/css/values/CSSValueTypes+DeprecatedCSSOMValueCreation.cpp:
Added.
* Source/WebCore/css/values/CSSValueTypes+DeprecatedCSSOMValueCreation.h: Added.
* Source/WebCore/css/values/CSSValueTypes.cpp:
* Source/WebCore/css/values/CSSValueTypes.h:
* Source/WebCore/css/values/borders/CSSBoxShadow.cpp: Removed.
* Source/WebCore/css/values/borders/CSSBoxShadow.h:
* Source/WebCore/css/values/color/CSSColor.cpp:
* Source/WebCore/css/values/content/CSSContent.cpp:
* Source/WebCore/css/values/content/CSSContent.h:
* Source/WebCore/css/values/filter-effects/CSSAppleColorFilter.cpp: Removed.
* Source/WebCore/css/values/filter-effects/CSSAppleColorFilter.h:
* Source/WebCore/css/values/filter-effects/CSSFilter.cpp: Removed.
* Source/WebCore/css/values/filter-effects/CSSFilter.h:
* Source/WebCore/css/values/fonts/CSSFontFamilyName.cpp:
* Source/WebCore/css/values/fonts/CSSFontFamilyName.h:
* Source/WebCore/css/values/masking/CSSClip.cpp:
* Source/WebCore/css/values/primitives/CSSCustomIdent.cpp:
* Source/WebCore/css/values/primitives/CSSKeyword.cpp:
* Source/WebCore/css/values/primitives/CSSKeyword.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRaw.h:
*
Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+DeprecatedCSSOMValueCreation.h:
* Source/WebCore/css/values/primitives/CSSString.cpp:
* Source/WebCore/css/values/primitives/CSSString.h:
* Source/WebCore/css/values/primitives/CSSURL.cpp:
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h:
* Source/WebCore/css/values/text-decoration/CSSTextShadow.cpp: Removed.
* Source/WebCore/css/values/text-decoration/CSSTextShadow.h:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/StyleCustomProperty.cpp:
* Source/WebCore/style/values/StyleValueTypes+DeprecatedCSSOMValueCreation.h:
Added.
* Source/WebCore/style/values/StyleValueTypes.h:
* Source/WebCore/style/values/backgrounds/StyleBorderImageOutset.cpp:
Canonical link: https://commits.webkit.org/314094@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
