Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4422fd9cac0cf462b6d4d1c9d9c41a130f0793d3
https://github.com/WebKit/WebKit/commit/4422fd9cac0cf462b6d4d1c9d9c41a130f0793d3
Author: Alan Baradlay <[email protected]>
Date: 2026-05-28 (Thu, 28 May 2026)
Changed paths:
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLTableColElement.cpp
M Source/WebCore/html/HTMLTextAreaElement.cpp
M Source/WebCore/html/NumberInputType.cpp
M Source/WebCore/mathml/MathMLFractionElement.cpp
M Source/WebCore/mathml/MathMLOperatorElement.cpp
M Source/WebCore/mathml/MathMLPaddedElement.cpp
M Source/WebCore/mathml/MathMLRootElement.cpp
M Source/WebCore/mathml/MathMLSpaceElement.cpp
M Source/WebCore/mathml/MathMLUnderOverElement.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/SettingsBase.cpp
M Source/WebCore/rendering/AutoTableLayout.cpp
M Source/WebCore/rendering/FixedTableLayout.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderFragmentContainer.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderLayerModelObject.cpp
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderObjectInlines.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderReplica.cpp
M Source/WebCore/rendering/RenderSlider.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableCol.cpp
M Source/WebCore/rendering/RenderTableCol.h
M Source/WebCore/rendering/RenderTableRow.cpp
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderTextControl.cpp
M Source/WebCore/rendering/RenderVideo.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/RenderViewTransitionCapture.cpp
M Source/WebCore/rendering/RenderWidget.cpp
M Source/WebCore/rendering/RenderWidget.h
M Source/WebCore/rendering/SubtreeScrollbarChangesState.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
M Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp
M Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
M Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
M Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp
M Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp
M Source/WebCore/rendering/mathml/RenderMathMLToken.cpp
M Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/svg/SVGSVGElement.cpp
Log Message:
-----------
[cleanup] Rename setNeedsPreferredWidthsUpdate to
invalidateContentLogicalWidths and align related cache-invalidation names
https://bugs.webkit.org/show_bug.cgi?id=315703
Reviewed by Antti Koivisto.
The cache-invalidation machinery for the min/max content logical widths used
two separate confusions: "Preferred" (the values aren't preferred, they're
min/max-content), and "setNeedsContentWidthsUpdate" (there's no real
"content widths update phase" - the function just marks the cache stale).
Switch to the WebKit-idiomatic invalidate / clearInvalidation pair, using
spec-aligned "ContentLogicalWidths" naming. The combo helper
setNeedsLayoutAndPreferredWidthsUpdate becomes setNeedsLayoutAndInvalidate-
ContentLogicalWidths.
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attributeChanged):
* Source/WebCore/html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::attributeChanged):
* Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::attributeChanged):
* Source/WebCore/html/NumberInputType.cpp:
(WebCore::NumberInputType::attributeChanged):
* Source/WebCore/mathml/MathMLFractionElement.cpp:
(WebCore::MathMLFractionElement::attributeChanged):
* Source/WebCore/mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::setOperatorFormDirty):
(WebCore::MathMLOperatorElement::attributeChanged):
* Source/WebCore/mathml/MathMLPaddedElement.cpp:
(WebCore::MathMLPaddedElement::attributeChanged):
* Source/WebCore/mathml/MathMLRootElement.cpp:
(WebCore::MathMLRootElement::childrenChanged):
* Source/WebCore/mathml/MathMLSpaceElement.cpp:
(WebCore::MathMLSpaceElement::attributeChanged):
* Source/WebCore/mathml/MathMLUnderOverElement.cpp:
(WebCore::MathMLUnderOverElement::attributeChanged):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::forceLayoutParentViewIfNeeded):
(WebCore::LocalFrameView::forceLayoutForPagination):
* Source/WebCore/page/SettingsBase.cpp:
(WebCore::SettingsBase::setNeedsRelayoutAllFrames):
* Source/WebCore/rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
* Source/WebCore/rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minContentContributionForGridItem
const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentContributionForGridItem
const):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutRenderBlockForScrollbarChange):
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
(WebCore::RenderBlock::layoutOutOfFlowBox):
(WebCore::markRendererAndParentForLayout):
(WebCore::RenderBlock::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderBlock::computeChildIntrinsicLogicalWidths const):
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::dirtyForLayoutFromPercentageHeightDescendant):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::updateStylesForColumnChildren):
(WebCore::RenderBlockFlow::invalidateLineLayout):
(WebCore::RenderBlockFlow::markInlineContentDirtyForLayout):
(WebCore::RenderBlockFlow::updateColumnProgressionFromStyle):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
(WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingInlinePath):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::shouldInvalidateContentWidths const):
(WebCore::RenderBox::minContentLogicalWidth const):
(WebCore::RenderBox::maxContentLogicalWidth const):
(WebCore::RenderBox::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderBox::shouldInvalidatePreferredWidths const): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::setNeedsLayoutForStyleDifference):
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::ScopedCrossAxisOverrideForFlexItem::ScopedCrossAxisOverrideForFlexItem):
(WebCore::RenderFlexibleBox::ScopedCrossAxisOverrideForFlexItem::~ScopedCrossAxisOverrideForFlexItem):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForFlexItem):
(WebCore::RenderFlexibleBox::flexBaseSizeForFlexItem):
(WebCore::RenderFlexibleBox::performFlexLayout):
(WebCore::RenderFlexibleBox::computeUsedMaxMainSize):
(WebCore::RenderFlexibleBox::computeUsedNonAutoMinMainSize):
(WebCore::RenderFlexibleBox::computeContentBasedMinMainSize):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::shouldInvalidateContentWidths const):
(WebCore::RenderImage::shouldInvalidatePreferredWidths const): Deleted.
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateValue):
(WebCore::RenderListItem::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListItem::usedCounterDirectivesChanged):
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::imageChanged):
(WebCore::RenderListMarker::updateInlineMarginsAndContent):
(WebCore::RenderListMarker::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::invalidateContentLogicalWidths):
(WebCore::RenderObject::invalidateContainerContentLogicalWidths):
(WebCore::RenderObject::setNeedsPreferredWidthsUpdate): Deleted.
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths): Deleted.
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::hasInvalidContentLogicalWidths const):
(WebCore::RenderObject::clearContentLogicalWidthsInvalidation):
(WebCore::RenderObject::needsPreferredLogicalWidthsUpdate const): Deleted.
(WebCore::RenderObject::clearNeedsPreferredWidthsUpdate): Deleted.
* Source/WebCore/rendering/RenderObjectInlines.h:
(WebCore::RenderObject::setNeedsLayoutAndInvalidateContentLogicalWidths):
(WebCore::RenderObject::setNeedsLayoutAndPreferredWidthsUpdate): Deleted.
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::intrinsicSizeChanged):
(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):
(WebCore::RenderReplaced::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderReplaced::shouldInvalidateContentWidths const):
(WebCore::RenderReplaced::shouldInvalidatePreferredWidths const): Deleted.
* Source/WebCore/rendering/RenderReplaced.h:
* Source/WebCore/rendering/RenderReplica.cpp:
(WebCore::RenderReplica::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
(WebCore::RenderTable::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::colSpanOrRowSpanChanged):
(WebCore::markCellDirtyWhenCollapsedBorderChanges):
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
(WebCore::RenderTableCol::updateFromElement):
(WebCore::RenderTableCol::clearContentLogicalWidthsInvalidation):
(WebCore::RenderTableCol::clearNeedsPreferredLogicalWidthsUpdate): Deleted.
* Source/WebCore/rendering/RenderTableCol.h:
* Source/WebCore/rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::trimmedPreferredWidths):
(WebCore::RenderText::minLogicalWidth const):
(WebCore::RenderText::maxLogicalWidth const):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::updateRenderedText):
(WebCore::RenderText::width const):
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp:
(WebCore::RenderViewTransitionCapture::intrinsicSizeChanged):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::shouldInvalidateContentWidths const):
(WebCore::RenderWidget::shouldInvalidatePreferredWidths const): Deleted.
* Source/WebCore/rendering/RenderWidget.h:
* Source/WebCore/rendering/SubtreeScrollbarChangesState.cpp:
(WebCore::SubtreeScrollbarChangesHandler::~SubtreeScrollbarChangesHandler):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::styleDidChange):
(WebCore::RenderMathMLBlock::adjustPreferredLogicalWidthsForBorderAndPadding):
(WebCore::RenderMathMLBlock::applySizeToMathContent):
* Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderMathMLToken::setMathVariantGlyphDirty):
* Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
(WebCore::resetRendererStateOnDetach):
(WebCore::RenderTreeBuilder::markBoxForRelayoutAfterSplit):
* Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::detach):
(WebCore::RenderTreeBuilder::Block::dropAnonymousBoxChild):
* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::attach):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::repaintAndMarkContainingBlockDirtyBeforeTearDown):
(WebCore::RenderTreeUpdater::tearDownRenderersInternal):
(WebCore::RenderTreeUpdater::tearDownTextRenderer):
* Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
Canonical link: https://commits.webkit.org/314106@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
