Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58ef21234ab508c2fefe249d3a43c49578bbdf79
https://github.com/WebKit/WebKit/commit/58ef21234ab508c2fefe249d3a43c49578bbdf79
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-05-29 (Fri, 29 May 2026)
Changed paths:
A
LayoutTests/media/modern-media-controls/icon-service/icon-service-bundle-load-expected.txt
A
LayoutTests/media/modern-media-controls/icon-service/icon-service-bundle-load.html
M LayoutTests/platform/visionos/TestExpectations
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
Log Message:
-----------
REGRESSION(312305@main): Books EPUB inline video controls icons are missing
https://bugs.webkit.org/show_bug.cgi?id=315884
rdar://177548584
Reviewed by Andy Estes and Tim Horton.
The "Copy Modern Media Controls Images" PBXCopyFilesBuildPhase introduced
in 312305@main replaced an rsync-based script that fell through to the
iOS icons for any non-macOS, non-watchOS platform. The replacement
attached `platformFilters = (ios, xros, );` to the iOS folder entries —
already omitting macCatalyst and tvOS — and the array was subsequently
collapsed to the singular `platformFilter = ios;` form in 312813@main
(almost certainly an unfortunate merge conflict resolution), excluding
visionOS as well.
As a result, WebCore.framework on visionOS, tvOS, and macCatalyst was
missing modern media controls images.
In this patch, we add (tvos, xros, maccatalyst) to platform filters,
matching the previous fall-through behavior of the rsync-based script.
We also add test coverage exercising the bundle path end-to-end via a
real <video controls> element. Existing tests manually set the icon
service directory path to the source tree, so we never fetch icons from
the framework's resources.
Test: media/modern-media-controls/icon-service/icon-service-bundle-load.html
*
LayoutTests/media/modern-media-controls/icon-service/icon-service-bundle-load-expected.txt:
Added.
*
LayoutTests/media/modern-media-controls/icon-service/icon-service-bundle-load.html:
Added.
* LayoutTests/platform/visionos/TestExpectations:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/314200@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
