Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2e23f5c960aed492c06f0924e5eba92660911d6a
https://github.com/WebKit/WebKit/commit/2e23f5c960aed492c06f0924e5eba92660911d6a
Author: Rupin Mittal <[email protected]>
Date: 2026-05-30 (Sat, 30 May 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
[Site Isolation] WebPageProxy::scheduleFullEditorStateUpdate() should send to
the correct web process
https://bugs.webkit.org/show_bug.cgi?id=315721
rdar://178098149
Reviewed by Aditya Keerthi.
Currently, WebPageProxy::scheduleFullEditorStateUpdate() only ever requests an
editor state update from the main frame's web process. But with site isolation,
a WebPageProxy is responsible for multiple web processes, so it should request
the editor state update from the process that currently contains the focused
frame, with the main frame's process as a backup.
There's no test because its unclear what this fixes. There are four callers of
this function, all in WKContentViewInteraction:
1. insertText
I manually tested that autocapitalization of words works with or without
changes to this function.
2. _scrollingNodeScrollingDidEnd
This was added in https://bugs.webkit.org/show_bug.cgi?id=290393. I verified
that the test added there does pass with and without site isolation on (even
when the test itself is refactored to be in a cross-site iframe).
3. _continueElementDidFocus
This was added in https://bugs.webkit.org/show_bug.cgi?id=214272. There was
no test added there.
4. willFinishIgnoringCalloutBarFadeAfterPerformingAction
This was added in https://bugs.webkit.org/show_bug.cgi?id=197532. The test
fixed there was removed in https://bugs.webkit.org/show_bug.cgi?id=241903
because the functionality it tested was removed.
We could possibly remove this function. EWS shows that removing it doesn't break
any tests (see the radar). But more manual testing should be done before
removing
it. So for now, we simply make it work with site isolation since it's possible
that things get fixed with site isolation on.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scheduleFullEditorStateUpdate):
Canonical link: https://commits.webkit.org/314227@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
