Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 79ae07732d4f6c6f92cee4089815cb76c2dc38b0
https://github.com/WebKit/WebKit/commit/79ae07732d4f6c6f92cee4089815cb76c2dc38b0
Author: Adrian Taylor <[email protected]>
Date: 2026-06-02 (Tue, 02 Jun 2026)
Changed paths:
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Scripts/generate-message-receiver.py
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/messages_unittest.py
R Source/WebKit/Scripts/webkit/tests/module.private.modulemap
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
[Swift GTK] Revert "Generate IPC modulemap"
https://bugs.webkit.org/show_bug.cgi?id=305643
rdar://168303740
Reviewed by Antoine Quint.
This reverts commit 9998c1385fe7bcb1f3d0a5b52e34a6a7e99522a8.
This commit added a modulemap for some of the DerivedSources generated for
WebKit IPC handling.
This modulemap appeared to solve some problems with template instantiation that
were caused by the textual inclusion of these headers within the
WebKit_Internal module. However:
- these problems no longer occur. There has been significant change to the
WebKit_Internal module and other modules since then, and these problems no
longer occur
- this change may in fact have been a no-op on Apple platforms.
- the existence of this module is causing insurmountable problems on Linux
builds.
More detail on these "insurmountable problems": there are circular dependencies
between headers in this IPC module and the main WebKit_Internal module.
These problems did not reveal themselves on the Mac because the new
WebKit_DerivedSources_IPC module was apparently never even being considered -
the module.private.modulemap was not being auto-detected because it was not
alongside a module.modulemap. So, this revert should in fact be a no-op.
An alternative considered here was to retain part of this change in that
it moved away a conflicting module.private.modulemap into a different directory
(that's an autogenerated modulemap). However, since the
module.private.modulemap is ignored anyway, it is cleanest to fully revert
this change.
Canonical link: https://commits.webkit.org/314367@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
