Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4ac8cc7833adeadf1bc4dcc117b1e9c88243e8bb
https://github.com/WebKit/WebKit/commit/4ac8cc7833adeadf1bc4dcc117b1e9c88243e8bb
Author: Luke Warlow <[email protected]>
Date: 2026-06-02 (Tue, 02 Jun 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-disabled-button-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-disabled-button.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/html/HTMLButtonElement.cpp
Log Message:
-----------
Popover light dismiss doesn't account for disabled command buttons
https://bugs.webkit.org/show_bug.cgi?id=308308
Reviewed by Tim Nguyen.
Updates HTMLButtonElement::commandForElement to return null when the button is
disabled.
Importantly this doesn't impact the commandForElement property as that uses the
[Reflect]
IDL extended attribute, NOT the commandForElement function.
Popover light dismiss spec:
https://html.spec.whatwg.org/multipage/popover.html#light-dismiss-open-popovers
Spec PR to account for command buttons:
https://github.com/whatwg/html/pull/12184
Test:
imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-disabled-button.html
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-disabled-button-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-disabled-button.html:
Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::commandForElement const):
Canonical link: https://commits.webkit.org/314400@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
