Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3fa40e65c4ec036c91e8a8c62f59e803530602cd
https://github.com/WebKit/WebKit/commit/3fa40e65c4ec036c91e8a8c62f59e803530602cd
Author: Brady Eidson <[email protected]>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/badging/setAppBadge_cross_origin.sub.https-expected.txt
M Source/WebCore/Modules/badge/NavigatorBadge.idl
M Source/WebCore/page/Navigator.cpp
M Source/WebCore/page/Navigator.h
M Source/WebCore/page/WorkerNavigator.cpp
M Source/WebCore/page/WorkerNavigator.h
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Badging.mm
Log Message:
-----------
Cross origin iframes should not be able to set the app badge.
rdar://173245853
https://bugs.webkit.org/show_bug.cgi?id=310638
Reviewed by Sihui Liu.
The steps for "set the application badge":
https://www.w3.org/TR/badging/#dfn-set-the-application-badge
...clearly point out that only script from an origin matching the top origin
can set the badge.
Otherwise a security error should result.
So let's implement that.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/Badging.mm
LayoutTests/imported/w3c/web-platform-tests/badging/setAppBadge_cross_origin.sub.https
*
LayoutTests/imported/w3c/web-platform-tests/badging/setAppBadge_cross_origin.sub.https-expected.txt:
* Source/WebCore/Modules/badge/NavigatorBadge.idl:
* Source/WebCore/page/Navigator.cpp:
(WebCore::Navigator::setAppBadge):
(WebCore::Navigator::clearAppBadge):
* Source/WebCore/page/Navigator.h:
* Source/WebCore/page/WorkerNavigator.cpp:
(WebCore::WorkerNavigator::setAppBadge):
(WebCore::WorkerNavigator::clearAppBadge):
* Source/WebCore/page/WorkerNavigator.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Badging.mm:
((Badging, CrossOrigin)):
((Badging, SameOrigin)):
((Badging, DISABLED_Origin)): Deleted.
Originally-landed-as: 305413.581@rapid/safari-7624.2.5.110-branch
(f0c6cc402623). rdar://176061670
Canonical link: https://commits.webkit.org/314758@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
