Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6eff33b688457c799dbb06dab7a59524ee732ba2
https://github.com/WebKit/WebKit/commit/6eff33b688457c799dbb06dab7a59524ee732ba2
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
A LayoutTests/webgl/webgl-timerquery-querycounter-gc-nocrash-expected.txt
A LayoutTests/webgl/webgl-timerquery-querycounter-gc-nocrash.html
M Source/WebCore/html/canvas/EXTDisjointTimerQuery.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGLObject.h
Log Message:
-----------
WebGL: Crash in EXTDisjointTimerQuery::queryCounterEXT task
https://bugs.webkit.org/show_bug.cgi?id=310345
rdar://172499466
Reviewed by Dan Glastonbury.
Take a ref of the query in the task EXTDisjointTimerQuery schedules
for making the query result available.
EXTDisjointTimerQueryWebGL2 was fixed in bug 303348.
Test: webgl/webgl-timerquery-querycounter-gc-nocrash.html
* LayoutTests/webgl/webgl-timerquery-querycounter-gc-nocrash-expected.txt:
Added.
* LayoutTests/webgl/webgl-timerquery-querycounter-gc-nocrash.html: Added.
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/html/canvas/EXTDisjointTimerQuery.cpp:
(WebCore::EXTDisjointTimerQuery::endQueryEXT):
(WebCore::EXTDisjointTimerQuery::queryCounterEXT):
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::endQuery):
* Source/WebCore/html/canvas/WebGLObject.h:
(WebCore::WebGLBindingPoint::releaseNonNull):
Originally-landed-as: 305413.551@rapid/safari-7624.2.5.110-branch
(479526084676). rdar://176061551
Canonical link: https://commits.webkit.org/314792@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
