Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c18ec1ad8a1dc3ed001583de6e44874967bc0540
https://github.com/WebKit/WebKit/commit/c18ec1ad8a1dc3ed001583de6e44874967bc0540
Author: Carlos Garcia Campos <[email protected]>
Date: 2026-06-09 (Tue, 09 Jun 2026)
Changed paths:
M Source/WebCore/platform/graphics/skia/SkiaGPUAtlas.cpp
M Source/WebCore/platform/graphics/skia/SkiaGPUAtlas.h
M Source/WebCore/platform/graphics/skia/SkiaPaintingEngine.cpp
M Source/WebCore/platform/graphics/skia/SkiaPaintingEngine.h
M Source/WebCore/platform/graphics/skia/SkiaRecordingResult.cpp
M Source/WebCore/platform/graphics/skia/SkiaRecordingResult.h
M Source/WebCore/platform/graphics/skia/SkiaReplayAtlas.cpp
M Source/WebCore/platform/graphics/skia/SkiaReplayAtlas.h
M Source/WebCore/platform/graphics/skia/SkiaReplayCanvas.cpp
Log Message:
-----------
[Skia] Move upload conditions handling from SkiaRecordingResult to
SkiaGPUAtlas
https://bugs.webkit.org/show_bug.cgi?id=316530
Reviewed by Nikolas Zimmermann.
The atlas now contains the AtlasUploadCondition and GLFence that are
signaled/created when upload is done. Then a new method
atlasImageForCurrentThread() waits for the upload and creates a SkImage
valid for the current thread. When deferred display list is implemented,
this method will return a promise image insetad of a rewrapped image.
This patch also renames SkiaReplayAtlas::atlasTexture() as atlasImage()
since it returns a SkImage and it was easy to confused with
SkiaGPUAtlas::atlasTexture() that returns a BitmapTexture.
* Source/WebCore/platform/graphics/skia/SkiaGPUAtlas.cpp:
(WebCore::SkiaGPUAtlas::SkiaGPUAtlas):
(WebCore::SkiaGPUAtlas::create):
(WebCore::SkiaGPUAtlas::uploadImages):
(WebCore::SkiaGPUAtlas::waitForUpload const):
(WebCore::SkiaGPUAtlas::atlasImageForCurrentThread const):
* Source/WebCore/platform/graphics/skia/SkiaGPUAtlas.h:
(WebCore::AtlasUploadCondition::create):
(WebCore::AtlasUploadCondition::addPending):
(WebCore::AtlasUploadCondition::signal):
(WebCore::AtlasUploadCondition::wait):
(WebCore::AtlasUploadCondition::WTF_GUARDED_BY_LOCK):
* Source/WebCore/platform/graphics/skia/SkiaPaintingEngine.cpp:
(WebCore::SkiaPaintingEngine::createAtlas):
(WebCore::SkiaPaintingEngine::record):
* Source/WebCore/platform/graphics/skia/SkiaPaintingEngine.h:
* Source/WebCore/platform/graphics/skia/SkiaRecordingResult.cpp:
(WebCore::SkiaRecordingResult::waitForUploadFence): Deleted.
(WebCore::SkiaRecordingResult::waitForUploadCondition): Deleted.
* Source/WebCore/platform/graphics/skia/SkiaRecordingResult.h:
(WebCore::AtlasUploadCondition::create): Deleted.
(WebCore::AtlasUploadCondition::addPending): Deleted.
(WebCore::AtlasUploadCondition::signal): Deleted.
(WebCore::AtlasUploadCondition::wait): Deleted.
(WebCore::AtlasUploadCondition::WTF_GUARDED_BY_LOCK): Deleted.
* Source/WebCore/platform/graphics/skia/SkiaReplayAtlas.cpp:
(WebCore::SkiaReplayAtlas::SkiaReplayAtlas):
(WebCore::SkiaReplayAtlas::create):
* Source/WebCore/platform/graphics/skia/SkiaReplayAtlas.h:
* Source/WebCore/platform/graphics/skia/SkiaReplayCanvas.cpp:
(WebCore::SkiaReplayCanvas::SkiaReplayCanvas):
(WebCore::SkiaReplayCanvas::onDrawImage2):
(WebCore::SkiaReplayCanvas::onDrawImageRect2):
Canonical link: https://commits.webkit.org/314797@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
