Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2b529d0974a9b5ddfc2d0d0be24db41b2af039a5
https://github.com/WebKit/WebKit/commit/2b529d0974a9b5ddfc2d0d0be24db41b2af039a5
Author: Sihui Liu <[email protected]>
Date: 2026-06-09 (Tue, 09 Jun 2026)
Changed paths:
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
Log Message:
-----------
[Site Isolation] Ensure BrowsingContextGroup::sharedProcessForSite does not
return cached process
https://bugs.webkit.org/show_bug.cgi?id=316633
rdar://179069275
Reviewed by Basuke Suzuki.
Site Isolation bots started to fail recently due to assertion failure in
WebPageProxy::continueNavigationInNewProcess:
`!newProcess->isInProcessCache()`. This seems related to recent enablement of
back-forward cache, but the root cause is
not yet fully understood: the shared process's FrameProcess is still alive
(BrowsingContextGroup::m_sharedProcess
WeakPtr is valid) while its underlying WebProcessProxy is added to cache.
Investigation is blocked by a separate issue
where high-volume media logs cause logd to quarantine UI process before crash,
making it hard to log and monitor
sequence of events.
To ensure bots can finish test run, this patch lands a temporary workaround to
clear shared frame process in
BrowsingContextGroup when the underlying process is in cache, letting the
caller fall through to processForNavigation to
pick a fresh process. This matches the safe-degradation behaviour already
implied by the existing (debug-only) ASSERT at
that site. Also, this patch adds some logging so we can debug deeper after
fixing the media log flood issue.
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
(WebKit::BrowsingContextGroup::sharedProcessForSite):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::maybeShutDown):
Canonical link: https://commits.webkit.org/314821@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
