Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d222ffc9fecaaacd5859962448b3c4c88d9996ec
https://github.com/WebKit/WebKit/commit/d222ffc9fecaaacd5859962448b3c4c88d9996ec
Author: Tyler Wilcock <[email protected]>
Date: 2026-06-09 (Tue, 09 Jun 2026)
Changed paths:
M Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm
Log Message:
-----------
AX: LocalFrame is used off the main-thread in accessibility isolated tree
mode tests, causing lots of assertions when running tests
https://bugs.webkit.org/show_bug.cgi?id=316436
rdar://178839190
Reviewed by Andres Gonzalez.
We cannot call WKBundleFrameForJavaScriptContext, as it requires
touching Documents and LocalFrames, which cannot be used off the
main-thread.
Fix this by hosting the WKBundleFrameForJavaScriptContext call out of the
lambda so the
WeakPtr<LocalFrame> walk happens on the main thread (where the JS callback
runs),
and store the result in a WKRetainPtr<WKBundleFrameRef>. We don't actually use
this
frame ref off the main-thread _WKAccessibilityRootObjectForTesting, so the
issue is avoided.
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::rootElement):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::accessibleElementById):
Canonical link: https://commits.webkit.org/314824@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
