Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c1d25a2ab560cf3df5f0d1d2b5708e3a446d5de1
https://github.com/WebKit/WebKit/commit/c1d25a2ab560cf3df5f0d1d2b5708e3a446d5de1
Author: Sam Sneddon <[email protected]>
Date: 2026-06-09 (Tue, 09 Jun 2026)
Changed paths:
M
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/cherry_pick_unittest.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/trace_unittest.py
Log Message:
-----------
[webkitscmpy] Unit tests should avoid relying on Tracker._tracker's global
state
https://bugs.webkit.org/show_bug.cgi?id=316708
Reviewed by Jonathan Bedard.
Per https://bugs.webkit.org/show_bug.cgi?id=316264, a number of tests
became flaky due to running tests in parallel with nondeterministic
sharding as a result of Tracker._trackers being mutated before they
ran.
We isolate these by using unittest.mock.patch to reset it to an empty
list before running tests in these test classes.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/cherry_pick_unittest.py:
(TestCherryPick.setUp):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(TestLand.setUp):
(TestLandGitHub.setUp):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/trace_unittest.py:
(TestCommitsStory.setUp):
(TestTrace.setUp):
Canonical link: https://commits.webkit.org/314864@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
